Bug 139660

Summary:	Paragraph panel alignment buttons should not be toggle buttons
Product:	LibreOffice	Reporter:	Jim Raykowski <raykowj>
Component:	UI	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	VERIFIED FIXED
Severity:	normal	CC:	caolan.mcnamara, ilmari.lauhakangas, jbfaure
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.1.5.2 release
Hardware:	All
OS:	All
Whiteboard:	target:7.3.0 target:7.1.7 target:7.2.2
Crash report or crash signature:		Regression By:

Description Jim Raykowski 2021-01-16 03:06:28 UTC

The Paragraph panel first row alignment buttons are toggle type buttons. When a highlighted button is clicked the button looses highlight.

To repro incorrect behavior in Writer:

1) Open Writer
2) Menu > View > Sidebar or Ctrl+F5
3) Properties deck (first button on the sidebar tab bar)
4) Click on any of the buttons in the first row of the Paragraph panel
button is highlighted
5) Click on the button again
button is not highlighted

Expected result: button remains highlighted

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 49e08318e5711f9cc85a52eb8efa21f35eafb7c7
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Comment 1 Jean-Baptiste Faure 2021-08-12 15:38:27 UTC

I reproduce this behavior in LO 7.2.1.0+ and LO 7.1.6.0+, but not in LO 6.4.7 under Ubuntu 20.04 x86-64. That is clearly an incorrect behavior because a paragraph must have an alignment.

Set to NEW and regression keyword added.

Best regards. JBF

Comment 2 Buovjaga 2021-08-26 11:52:09 UTC

Bibisected with linux-64-7.0 to
https://git.libreoffice.org/core/commit/006f4caf543d6d6ce5f069b2af8c2ba982dcfb62
weld ParaPropertyPanel

Adding Cc: to Caolán McNamara

Comment 3 Commit Notification 2021-08-26 18:41:39 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d2015efaaaa1e98454c6e9e1b6083bd7103fbab3

tdf#139660 one of the group needs to be active

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Caolán McNamara 2021-08-26 18:51:08 UTC

done in trunk, backport to 7-2 and 7-1 in gerrit

Comment 5 Commit Notification 2021-08-26 19:50:32 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/01bcfc465a26ca2bdad6ed5c8d03698d02327c52

tdf#139660 one of the group needs to be active

It will be available in 7.1.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 Commit Notification 2021-08-26 19:51:45 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/b30f30fdcc00a254943c39971b0f7f3769ec4f78

tdf#139660 one of the group needs to be active

It will be available in 7.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Buovjaga 2021-08-26 20:05:24 UTC

Verified, thanks!

Arch Linux 64-bit
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 9ed35109abb4179a3ab77498f550b4b9868e9cbc
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 26 August 2021