| Summary: | Tools > Autocorrect > Apply with "Capitalize first letter in every sentence" [M] does not work on first sentence of a document following an initial empty paragraph | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | sdc.blanco |
| Component: | LibreOffice | Assignee: | Justin L <jluth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jluth, michael.stahl, raal, vsfoote |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.2.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=74363 | ||
| Whiteboard: | target:7.3.0 target:7.2.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103341 | ||
| Attachments: | autoCorrect.odt: open and just run Tools - AutoCorrect - Apply | ||
|
Description
sdc.blanco
2021-01-26 10:51:06 UTC
Confirmed. But, note that the Default PS of the text in now 2nd paragraph is changed to Text Body PS, so an autoformat was applied. Just not the AF capitalization of the first sentence following an initial empty paragraph. Subsequent empty paragraphs do not affect capitalization of following paragraphs. // Capitalize first letter of every sentence 844 void SvxAutoCorrect::FnCapitalStartSentence https://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx?r=94306083#844 Suspect work on bug 108795 making the autocorrect stateful in the SvxAutoCorrect::DoAutoCorrect https://cgit.freedesktop.org/libreoffice/core/commit/?id=c5fcab1ec72be1cf2868215ee71d3cb2668498c1&h=libreoffice-5-4 This issue does not occur in a build of 5.3.7.2 on hand, but needs a proper bibisect. This seems to have begun at the below commit. Adding Cc: to Michael Stahl ; Could you possibly take a look at this one? Thanks bibisect-linux-64-6.2$ 01607703b961a83952bb39822a023c4d75c3136c is the first bad commit commit 01607703b961a83952bb39822a023c4d75c3136c Author: Jenkins Build User <tdf@pollux.tdf> Date: Fri Dec 7 19:26:05 2018 +0100 source 4cf5a46f16dec8ce16c6662ce5c17903e28b8fa3 commit 4cf5a46f16dec8ce16c6662ce5c17903e28b8fa3 [log] author Michael Stahl <Michael.Stahl@cib.de> Wed Nov 28 15:51:02 2018 +0100 committer Thorsten Behrens <Thorsten.Behrens@CIB.de> Fri Dec 07 13:08:58 2018 +0100 tree e65deb9f6801c6b45ad5cbdebb1d6baaae51a969 parent 180e5f515c9cd21fb8057c797a480eca7d9ed260 [diff] sw_redlinehide_4a: SwAutoCorrDoc iterates frames, not nodes bisected Test 2. confirmed the bibisect. Updated the earliest affect version to 6.2. Proposed fix at https://gerrit.libreoffice.org/c/core/+/125037 Created attachment 176188 [details]
autoCorrect.odt: open and just run Tools - AutoCorrect - Apply
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/59dc5d00b04927d07df2dcc3c17acfdc760d8765 tdf#139922 sw autocorr: don't return GetPrevPara if isEmpty It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/133fe29d06445daadc556cff013d5194a883ea9b tdf#139922 sw autocorr: don't return GetPrevPara if isEmpty It will be available in 7.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/837bb7370b702399562a3b0b4e444237c66879a8 tdf#139922: sw_uiwriter3: Add unittest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. 7.2.4 was a hotfix release, updating target in status-whiteboard |