| Summary: | EDITING: can't edit OLE object | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
| Component: | Impress | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, needUITest, regression |
| Version: | 6.4.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=128631 https://bugs.documentfoundation.org/show_bug.cgi?id=113955 |
||
| Whiteboard: | target:7.2.0 target:7.1.1 target:7.0.5 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Xisco Faulí
2021-02-02 08:36:33 UTC
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=913b2530fff20bacb0cbb8e51be29b42983d56c8 author Caolán McNamara <caolanm@redhat.com> 2019-11-06 15:00:55 +0000 committer Caolán McNamara <caolanm@redhat.com> 2019-11-06 20:50:22 +0100 commit 913b2530fff20bacb0cbb8e51be29b42983d56c8 (patch) tree a2ed349d04099e07d77e2c6307e48896ecc78eac parent ef0e7e146f86999b04d7274688d72fadcaf53a36 (diff) Resolves: tdf#128631 dispatch active ole async Bisected with: bibisect-linux64-6.4 Adding Cc: to Caolán McNamara The click is ignored because at sfx2/source/view/viewfrm2.cxx:305 case SID_OBJECT GetViewShell()->GetVerbs().hasElements() is empty so SID_OBJECT is ignored Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d084836102fdf3a486bd8c01f55ae0a5a673d10 tdf#140079 Claim support for the OleEmbeddedObject::doVerb -9 fallback It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. These embedded objects are on the "fallback to try and get libreoffice itself to open them" path so the above seems reasonable to return this fallback mode as the list of things the object supports rather than nothing. Hard to know if there will be unforseen consequences. Backport just to 7-1 in gerrit for now. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/01f2379603de09ba1b5e979166e4b5d60a90c1d5 tdf#140079 Claim support for the OleEmbeddedObject::doVerb -9 fallback It will be available in 7.1.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: dc1b416c684c4e2525978e48252d55d78adcfca8 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, thanks for fixing this issue!! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/b38f2625ef48d85ece632a951dca8db6df407049 tdf#140079 Claim support for the OleEmbeddedObject::doVerb -9 fallback It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I added a similar UItest in https://cgit.freedesktop.org/libreoffice/core/commit/?id=82010c9faad479d6aee5b69da717db49be9b5653, but this bug is about the double-click, which is not tested in this UItest |