| Summary: | Password protection doesn't work (Win 7 only) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Roman Kuznetsov <79045_79045> |
| Component: | LibreOffice | Assignee: | Aron Budea <aron.budea> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | aron.budea, vmiklos, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108914 | ||
|
Description
Roman Kuznetsov
2021-02-07 10:38:40 UTC
I can't reproduce it in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 40b56cd8da8c38582dc4660b486993d1b4711535 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded nor with gen. Win only ? NOT reproducible Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win Locale: ja-JP (ja_JP); UI: en-US Calc: CL (In reply to Xisco Faulí from comment #1) > I can't reproduce it in > > Version: 7.2.0.0.alpha0+ / LibreOffice Community > Build ID: 40b56cd8da8c38582dc4660b486993d1b4711535 > CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 > Locale: en-US (en_US.UTF-8); UI: en-US > Calc: threaded > > nor with gen. Win only ? May be Win 7 only even? I can confirm on Windows 7, and have encountered likely the same issue recently when running unit tests, CppunitTest_services failed when trying to instantiate com.sun.star.security.CertificateContainer, because loading xmlsecurity.dll failed. As far as I can see, the problem is with a call to LoadPackagedLibrary in libxmlsec, which only exists since Windows 8: https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-loadpackagedlibrary The call is here: https://github.com/lsh123/xmlsec/blob/21bbcb04b62352331a15a0b8463ebb27a9b858bc/src/dl.c#L160 And was added with the following commit: https://github.com/lsh123/xmlsec/commit/3ecf7d2ad4fd8017cd803b98962872799def621a Commenting out the added lines, and rebuilding xmlsec and LO fixes both the unit test failure, and the issue reported here. Btw, not just Calc is affected, password protection of files doesn't work in the other apps, either. Aron Budea committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9b61c811e43991e61505d32776a59c03c00dc58a tdf#140234: Fix xmlsec on Windows 7 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Should be fine now, please retest with a daily build containing the fix. verified in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2c8ffa41ec8e1ab2af95d5e033a445c17d29cf5a CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL Jumbo Thanks for fix! |