Bug 140361

Summary:	Calc: Edit Hyperlink in context menu doesn't work if link isn't selected (GTK3)
Product:	LibreOffice	Reporter:	Aron Budea <aron.budea>
Component:	Calc	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	medium
Version:	6.4.0.3 release
Hardware:	All
OS:	Linux (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=137445
Whiteboard:	target:7.3.0 target:7.2.0.0.beta2 target:24.2.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103182, 120543
Attachments:	Sample ODS with a hyperlink

Description Aron Budea 2021-02-12 05:45:04 UTC

Created attachment 169696 [details]
Sample ODS with a hyperlink

This seems similar to bug 137445, but in Calc.

Open the attached sample, right-click the hyperlink, and choose Edit Hyperlink.

-> Nothing happens.

It seems this only happens if you right-click over the right half of the link, which puts the caret at the end of the hyperlink. If you right-click over the left half, the caret goes to the beginning of the hyperlink, and the dialog opens fine.

Occurs with gtk3 VCL plugin, the dialog pops up with gen VCL plugin, and is populated with the link.
The menu option was changed/added in 6.4, in 6.3 there is a Hyperlink item in the context menu, which opens the dialog, but it isn't populated, and isn't for changing the existing link.

Observed in LO 7.2.0.0.alpha0+ (066799b4a162aa0a4bc6aa28339f1f943a13971e), 6.4.0.3 / Ubuntu.

Comment 1 Caolán McNamara 2021-06-22 10:50:01 UTC

I can try the same solution there for here

Comment 2 Commit Notification 2021-06-22 13:29:27 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d9a5302ca8bef90914539c12adb6c81496c28504

Resolves: tdf#140361 use the DisableEditHyperlink state as of menu launch time

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Commit Notification 2021-06-22 13:29:40 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/66e234549a15cad1b5b61661fb28c7f827ed6e8b

Resolves: tdf#140361 use the DisableEditHyperlink state as of menu launch time

It will be available in 7.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Commit Notification 2023-11-15 19:04:23 UTC

Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/61d2d34b882b2b89c6702b04764058931ba70d60

tdf#158031 Revert "tdf#140361 use the DisableEditHyperlink state

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.