| Summary: | Add barcode support into QR code dialog | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Buovjaga <ilmari.lauhakangas> |
| Component: | UI | Assignee: | Homeboy_445 <akshitsan13> |
| Status: | VERIFIED FIXED | ||
| Severity: | enhancement | CC: | 79045_79045, akshitsan13, heiko.tietze, mentoring, minute.visitors, mueller-fr, samuel.mehrbrodt, thom1fr, vsfoote, xiscofauli |
| Priority: | medium | Keywords: | difficultyInteresting, easyHack, skillCpp, topicUI |
| Version: | 7.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=139778 https://bugs.documentfoundation.org/show_bug.cgi?id=67090 https://bugs.documentfoundation.org/show_bug.cgi?id=145728 |
||
| Whiteboard: | target:7.3.0 inReleaseNotes:7.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 127232, 128779 | ||
|
Description
Buovjaga
2021-03-23 09:22:28 UTC
*** Bug 67090 has been marked as a duplicate of this bug. *** Should we inculcate the functionality within the existing QR code dialog box by adding a feature like drop-down or something where the user could select either Qr code or Bar code and generate it as it does right now or should a new dialog box be created for serving this purpose? Creating API for QR codes should depend on this: only after implementing more formats, the API should appear and allow creation of any of those types. (In reply to Homeboy_445 from comment #2) > Should we inculcate the functionality within the existing QR code dialog box > by adding a feature like drop-down or something where the user could select > either Qr code or Bar code and generate it as it does right now or should a > new dialog box be created for serving this purpose? Please use the existing dialog and add a dropdown (or similiar) where you can chose the type (as it's written in the bug title). Ask #libreoffice-design IRC channel if you need a mockup. I didn't try the current commit at gerrit. However I'm asking myself: What will the menu entry be after this gets pushed. Will Insert -> Object -> QR-code being changed into Barcode? I personally struggle a bit with the idea of renaming QR-code to Barcode. A QR-code might be a species of the genus barcode. However I associate 'barcode' with "Linear barcodes" and less with "Matrix (2D) barcodes". Visa visa the same is true. QR code isn't a "Linear barcodes" So barcode might be technically proper description. However this might be easy misinterpreted in everyday speech. Not that having the ideal solution here: A) 2 entry's point to the same dialog. But well this might be seen as bloat. B) Calling it "QR- Barcode" C) Barcode D) Something else? *** Bug 145075 has been marked as a duplicate of this bug. *** Some 2d codes : https://barcode.tec-it.com/en/DataMatrix homeboy445 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d37a44a9ebdafec1435f98194417a1d8cc8208b5 tdf#141193 Added support for bar codes in qrcode dialog box[API Change]. It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified on: Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community Build ID: f4b353c1f52fc78a102413cac94c7fb24292bec6 CPU threads: 8; OS: Windows 10.0 Build 22483; UI render: Skia/Vulkan; VCL: win Locale: es-MX (es_MX); UI: es-ES Calc: threaded The menu item still needs to be renamed to match the new dialog title, and I would move the Type combo box to be at the very top of everything else, but the functionality is there and it works! Thanks a lot Akshit! Reviewing release notes. I added a picture for this feature: https://wiki.documentfoundation.org/ReleaseNotes/7.3#Core_.2F_General Hi. Would it also be possible to create a barcode variant with a text label? Thanks (In reply to kabilo from comment #11) > Hi. Would it also be possible to create a barcode variant with a text label? > Thanks Please open a new report It would have been nice to know what type of barcode the: Insert -> Object -> QR and Barcode... is actually inserting, as there are dozns of different barcodes and not all barcode readers can read them all: https://extensions.libreoffice.org/en/extensions/show/barcode https://en.wikipedia.org/wiki/Barcode#Linear_barcodes |