Bug 141634

Summary:	Allow entering a new subhead below a subhead that has content hidden beneath it.
Product:	LibreOffice	Reporter:	j.a.swami
Component:	Writer	Assignee:	Jim Raykowski <raykowj>
Status:	VERIFIED FIXED
Severity:	enhancement	CC:	dgp-mail, raykowj
Priority:	medium
Version:	7.2.0.0.alpha0+
Hardware:	All
OS:	All
Whiteboard:	target:7.3.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	135310

Description j.a.swami 2021-04-11 23:58:49 UTC

Description:
When the content beneath a subhead is hidden, placing the cursor after the subhead and pressing “enter” does nothing; the cursor will appear frozen. This would be the preferred behavior: Pressing “enter” after the subhead would place me on a new blank line after the hidden content and at the same level as the subhead my cursor had been placed after.

Steps to Reproduce:
1.Open a document with various levels of text.
2.Enable "folding outline" mode by clicking "show outline visibility content" button.
3.Place cursor after a subhead that has content hidden beneath it. 
4.Press enter.

Actual Results:
Nothing happens. The cursor appears frozen.

Expected Results:
I would expect to be placed on a new blank line after the hidden content and at the same level as the subhead my cursor had been placed after. On this blank line, I want to be ready to enter a new subhead, at the same level as the one I've just left. 

When I want to see my present subhead and enter a new one after it -- a circumstance in which writers often find themselves -- this behavior would be useful, natural, and intuitive.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: a22357213807fa46b903e7d040809cff194c39af
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-03-29_12:01:23
Calc: threaded

Comment 1 Dieter 2021-04-27 06:32:01 UTC

Tested with

Version: 7.1.3.1 (x64) / LibreOffice Community
Build ID: fa76d07d7006a0e2866c3247cef2d5eb55ae8369
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Ressult: Cursor is still at the end of the subhead and is active. So waht I can see, is, that CR doesn't work, but I don't know, if this is the expected behaviour.

cc: Jim Raykowski

Jim, I'm sure you can answer the question about the expected behaviour and the enhancement request.

Comment 2 Jim Raykowski 2021-04-29 01:00:06 UTC

I think it's a good suggestion. This will be a special case where the heading style next style is not used. Instead a new heading of the same level would be inserted after the folded outline content.

Comment 3 Jim Raykowski 2021-10-18 20:29:51 UTC

Here is effort to realize the enhancement request:
https://gerrit.libreoffice.org/c/core/+/123747

Comment 4 Commit Notification 2021-10-21 21:36:13 UTC

Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/827c0f9766f148520aed7fe3abe2b138a157a6d3

tdf#141634 Special end of para split for folded outline node

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 5 Dieter 2021-11-13 08:27:22 UTC

VERIFIED with

Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 742b8befecbcfc0cfab87cfcd87c83b7d8ef32ab
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Jim, thank you for this improvement!