| Summary: | "Libreoffice community" image is invisible on Gtk dark theme | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Paul Kepinski <paul.kepinski> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, heiko.tietze, paul.kepinski, xiscofauli |
| Priority: | medium | ||
| Version: | 7.1.2.2 release | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=141733 | ||
| Whiteboard: | target:7.2.0 target:7.1.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103184 | ||
| Attachments: | Invisible LO image | ||
|
Description
Paul Kepinski
2021-04-23 18:22:03 UTC
Created attachment 171374 [details]
Invisible LO image
You desktop environment is Qt-based? We have dark or bright brand images depending on the default application background. And apparently you run LibreOffice in dark while the default is bright. I'm using Ubuntu 21.04 with Gnome (Gtk so). Also I'm using Yaru theme, and there is a problem with the dark variant (also tested Adwaita dark: same problem). [Automated Action] NeedInfo-To-Unconfirmed Installed Ubuntu in a VM and even the inbuilt dark mode doesn't work. The about box uses the image for bright themes. Any idea, Caolan, what's wrong with Ubuntu? Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8db72947d7bd6eda08b95a13b63a5f0503564639 Related: tdf#141857 send style-updated after app settings are updated It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán, is this also a fix for bug 141733? I doubt it, what's pushed so far only affects updates done directly after toggling dark/light mode. The next thing to be pushed will only affect the image in the sidebar so I expect bug 141733 to remain unchanged. That tabbar is one of the last things not using "real" gtk widgets in the gtk mode UI, finishing that might help there. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/84b4bca314ded015911ab986e8f999518616b248 Resolves: tdf#141857 update background to current theme It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. looks ok in main, backports to 7-1 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/c0de03044e2a4db8731fdbd128ceca81468d4f6a Related: tdf#141857 send style-updated after app settings are updated It will be available in 7.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/0c866752bd1abc19689db22c782a8b62ace24fa3 Resolves: tdf#141857 update background to current theme It will be available in 7.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |