Bug 141926

Summary:	FILEOPEN PPTX Dash – Dot style line loses some dots in presentation mode (Windows with GDI)
Product:	LibreOffice	Reporter:	NISZ LibreOffice Team <libreoffice>
Component:	Impress	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	aron.budea, ilmari.lauhakangas, nemeth, varga.balazs3, xiscofauli
Priority:	medium	Keywords:	filter:pptx
Version:	7.2.0.0.alpha0+
Hardware:	All
OS:	Windows (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=136957 https://bugs.documentfoundation.org/show_bug.cgi?id=150426
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	136372
Attachments:	Example file from PowerPoint (reused from unit test of bug 134053) Screenshot of the original document side by side in PowerPoint and Impress Screenshot of the problem in Impress slideshow mode The example file in Impress slideshow mode How it looks in yesterdays nightly Another example file with more line widths The latest example in editor mode The new example file in slideshow mode

Description NISZ LibreOffice Team 2021-04-27 08:44:49 UTC

Created attachment 171440 [details]
Example file from PowerPoint (reused from unit test of bug 134053)

This is a followup to bug #136957
Attached example file has a line shape with dash – dot line style set.
In editor mode the line looks like in PowerPoint, but in slideshow mode some dots disappear between the dashes.

Steps to reproduce:
    1. Open attached file
    2. Press F5 to start the slideshow

Actual results:
Some dots are missing.

Expected results:
Continuous dash-dot pattern.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: eeb2854e085fdd9f7a38d6e952a8aedf43e90323
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Comment 1 NISZ LibreOffice Team 2021-04-27 08:45:14 UTC

Created attachment 171441 [details]
Screenshot of the original document side by side in PowerPoint and Impress

Comment 2 NISZ LibreOffice Team 2021-04-27 08:45:39 UTC

Created attachment 171442 [details]
Screenshot of the problem in Impress slideshow mode

Comment 3 Xisco Faulí 2021-04-27 15:58:03 UTC

Luboš is reverting the fix for tdf#136957 in https://gerrit.libreoffice.org/c/core/+/114711 and providing another solution in https://gerrit.libreoffice.org/c/core/+/114710

Comment 4 Gabor Kelemen (allotropia) 2021-04-30 13:15:49 UTC

Created attachment 171529 [details]
The example file in Impress slideshow mode

Looks more consistent in a fresh build after this commit:

https://bugs.documentfoundation.org/show_bug.cgi?id=136957#c17

Version: 7.2.0.0.alpha0+
Build ID: 6b7c2fa65eb68be520ed4135cc245e33fa22e8bf
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Comment 5 NISZ LibreOffice Team 2021-05-07 07:13:31 UTC

Created attachment 171731 [details]
How it looks in yesterdays nightly

Looks good on Windows with Skia, but not with GDI graphics:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9df3aa7ea72d61462e430643f2a80906dce4e15b
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Comment 6 NISZ LibreOffice Team 2021-05-10 09:52:51 UTC

Created attachment 171817 [details]
Another example file with more line widths

Let me move the goal post here...

This file contains some line objects with different widths: 2 pt, 1 pt, 6 pt and 10 pt.

In GDI mode during slideshow the dashes get longer and the space between them gets longer than in editing mode.
 
The dots now appear after

https://git.libreoffice.org/core/commit/ec73a21bccf4a055ae9dc575dbad3d67c91f481e

set also dashing cap style for directx canvas (tdf#136957)

Comment 7 NISZ LibreOffice Team 2021-05-10 09:54:19 UTC

Created attachment 171818 [details]
The latest example in editor mode

Comment 8 NISZ LibreOffice Team 2021-05-10 09:59:00 UTC

Created attachment 171819 [details]
The new example file in slideshow mode

In todays nightly:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1675a68526c43c6c6e4dc850ee911f0c1de75c88
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

However it looks like in the editor during slideshow in Skia mode.

Comment 9 Gerald Pfeifer 2021-05-10 10:22:34 UTC

Is this Windows-specific now (given the GDI references)?  I set "Windows"
as platform, and wonder whether the title should reflect this, too?

Comment 10 Buovjaga 2022-04-19 06:46:32 UTC

Repro only on Win with default render.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: efb39149be1744def96ef015d1d184b5af3f43b7
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo