Bug 141954

Summary: Some Default Character Styles not translated in Customize Toobar dialog
Product: LibreOffice Reporter: Olivier Hallot <olivier.hallot>
Component: WriterAssignee: Olivier Hallot <olivier.hallot>
Status: RESOLVED FIXED    
Severity: normal CC: heiko.tietze, kelemeng, serval2412, xiscofauli
Priority: medium    
Version: 7.2.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:7.2.0
Crash report or crash signature: Regression By:

Description Olivier Hallot 2021-04-28 23:42:59 UTC 
Step to reproduce

1) on a non English user interface, have a text document open.
2) open Tools - Customize - Toolbar
3) Select Formatting (styles) toolbar on the right
4) Notice some English names in styles

Some character style name hard coded in toolbar and not localizable. File to touch seems to be 
sw/uiconfig/swriter/toolbar/textstylebar.xml 
and 
sw/uiconfig/sglobal/toolbar/textstylebar.xml

The untranslatable strings seems to have toolbar:text= attribute non empty. The attribute value is the name seen in the Customize dialog right pane.

grep 'toolbar:text=' sw/uiconfig/swriter/toolbar/textstylebar.xml

<toolbar:toolbaritem xlink:href=".uno:DefaultParaStyle" toolbar:text="Default"/>
 <toolbar:toolbaritem xlink:href=".uno:Heading1ParaStyle" toolbar:text="H1"/>
 <toolbar:toolbaritem xlink:href=".uno:Heading2ParaStyle" toolbar:text="H2"/>
 <toolbar:toolbaritem xlink:href=".uno:Heading3ParaStyle" toolbar:text="H3"/>
 <toolbar:toolbaritem xlink:href=".uno:Heading4ParaStyle" toolbar:text="H4" toolbar:visible="false"/>
 <toolbar:toolbaritem xlink:href=".uno:Heading5ParaStyle" toolbar:text="H5" toolbar:visible="false"/>
 <toolbar:toolbaritem xlink:href=".uno:Heading6ParaStyle" toolbar:text="H6" toolbar:visible="false"/>
 <toolbar:toolbaritem xlink:href=".uno:TextBodyParaStyle" toolbar:text="Text"/>
 <toolbar:toolbaritem xlink:href=".uno:QuoteParaStyle" toolbar:text="Quote"/>
 <toolbar:toolbaritem xlink:href=".uno:PreformattedParaStyle" toolbar:text="Pre"/>
 <toolbar:toolbaritem xlink:href=".uno:StyleApply" toolbar:text="Character Styles" toolbar:visible="false"/>
 <toolbar:toolbaritem xlink:href=".uno:SourceCharStyle" toolbar:text="Code"/>
 <toolbar:toolbaritem xlink:href=".uno:StyleApply?Style:string=User Entry&amp;FamilyName:string=CharacterStyles" toolbar:text="User" toolbar:visible="false"/>
 <toolbar:toolbaritem xlink:href=".uno:StyleApply" toolbar:text="List Styles" toolbar:visible="false"/>

Which seems to correspond to the untranslatable character style in the customize dialog.

Possibly, removing the attribute "toolbar:text" above, and the l10n cycle can pick the right translation.
Comment 1 Julien Nabet 2021-04-29 07:18:16 UTC 
Gabor/Heiko/Xisco: it seems reasonable to me, any thoughts here?
Comment 2 Julien Nabet 2021-04-29 07:24:07 UTC 
Just for the record because I hadn't seen it, you've already submitted a patch to gerrit here:
https://gerrit.libreoffice.org/c/core/+/114825
Comment 3 Commit Notification 2021-04-29 13:09:06 UTC 
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8bde607cae2d9c0edb013aae975bde1ddba388a8

tdf#141954 Enable l10n in Formatting bar customization

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2022-05-03 12:09:00 UTC 
A polite ping to Olivier Hallot:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks