| Summary: | [EMF] Path with PolylineTo + StrokeAndFill = wrong pen width for a stroke | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Valek Filippov <frob> |
| Component: | graphics stack | Assignee: | Bartosz <gang65> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | 79045_79045, bugzilla, gang65, xiscofauli |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.2.0 target:7.1.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103859 | ||
| Attachments: |
EMF sample with Path/PolylineTo/StrokeAndFill
Screenshot for the attached sample opened in MSO Screenshot from LO Screenshot for the attached sample opened in MSO win10 EMF sample with PolylineTo and FillPath Screenshot for PolylineTo+FillPath opened in MS Paint EMF with two arcs, one with default pen, another with pen width=0 (PS_GEOMETRIC) Screenshot with default and "w=0" pen from MS Paint Comparison LibreOffice 7.1 (KO), LibreOffice 7.2 master (OK) and MSO 2010 |
||
|
Description
Valek Filippov
2021-05-01 12:04:12 UTC
Created attachment 171558 [details]
EMF sample with Path/PolylineTo/StrokeAndFill
Created attachment 171559 [details]
Screenshot for the attached sample opened in MSO
Created attachment 171560 [details]
Screenshot from LO
This screenshot shows two files: with 'StrokePath' and with 'StrokeAndFillPath'.
Stroke around filled shape should be as thick as on the non-filled one.
Created attachment 171566 [details]
Screenshot for the attached sample opened in MSO win10
Looks like MSO on Mac doesn't do it properly too.
[MS-EMF] claims that:
'The EMR_STROKEANDFILLPATH record closes any open figures in a path, strokes the outline of the path by using the current pen, and fills its interior by using the current brush.'
However, it looks like it first strokes, then closes and fills.
There is no stroke on the bottom left side of the triangle in windows implementation.
confirm in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: a52590d76b89dc75be2aa87f4287624c89f1e82f CPU threads: 4; OS: Mac OS X 11.3; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded Created attachment 171926 [details]
EMF sample with PolylineTo and FillPath
As per Bartosz request
Created attachment 171927 [details]
Screenshot for PolylineTo+FillPath opened in MS Paint
*** Bug 112603 has been marked as a duplicate of this bug. *** Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b5ece3fbc7f878846298fd9196e5a30ba50e0dc2 tdf#112603 tdf#142014 tdf#142139 WMF/EMF Fix line width It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/3ffc0afce0f26900a4e1d9feed2c21108e1ed41b tdf#112603 tdf#142014 tdf#142139 WMF/EMF Fix line width It will be available in 7.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 171961 [details]
EMF with two arcs, one with default pen, another with pen width=0 (PS_GEOMETRIC)
As per Bartosz request
Created attachment 171962 [details]
Screenshot with default and "w=0" pen from MS Paint
Smaller arc has pen with width=0. Probably it shouldn't be displayed.
Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/699295ca7cab3a4f4e801a14496f202c05d18899 tdf#142014 Fix displaying strokes when line width is 0 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Bartosz Kosiorek committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/c0e6031e173c2c0efe0715af9fd8dd205c74a030 tdf#142014 Fix displaying strokes when line width is 0 It will be available in 7.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 172093 [details]
Comparison LibreOffice 7.1 (KO), LibreOffice 7.2 master (OK) and MSO 2010
Verified in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: c781776f3c79bbe3175b1452d26c79ebb931a500 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Bartosz, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ? |