Bug 142037

Summary:	[WMF/EMF] ExcludeClipRect is not supported
Product:	LibreOffice	Reporter:	Valek Filippov <frob>
Component:	graphics stack	Assignee:	Bartosz <gang65>
Status:	ASSIGNED ---
Severity:	normal	CC:	79045_79045, aron.budea, gang65
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103859
Attachments:	EMF sample ExcludeClipRect + Rectangle Screenshot of the sample file in MSO for win EMF sample with xform, exclip and ellipse Screenshot ofthe xform-exclip-ellipse opened in MS Paint WMF sample with regular and inverted coords for ExcClipRect Screenshot of the WMF sample opened in MS Paint

Description Valek Filippov 2021-05-02 00:26:48 UTC

Description:
LO seems to ignore ExcludeClipRect EMR.

Steps to Reproduce:
Open attached EMF sample in LO.

Actual Results:
LO draws a rectangle with black stroke and yellow fill.

Expected Results:
Rectangle should have 'excluded' area as on the attached screenshot from MSO on win.


Reproducible: Always


User Profile Reset: No



Additional Info:
Wordpad seems to render it reasonably well too.

Comment 1 Valek Filippov 2021-05-02 00:27:54 UTC

Created attachment 171583 [details]
EMF sample ExcludeClipRect + Rectangle

Comment 2 Valek Filippov 2021-05-02 00:28:22 UTC

Created attachment 171584 [details]
Screenshot of the sample file in MSO for win

Comment 3 Roman Kuznetsov 2021-05-03 13:38:44 UTC

confirm in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: a52590d76b89dc75be2aa87f4287624c89f1e82f
CPU threads: 4; OS: Mac OS X 11.3; UI render: default; VCL: osx
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded

Comment 4 Valek Filippov 2021-05-07 16:20:45 UTC

It also seems to be missed in WMF.

Sample is here: https://bugs.documentfoundation.org/attachment.cgi?id=171753
Screenshot: https://bugs.documentfoundation.org/attachment.cgi?id=171754

Comment 5 Valek Filippov 2021-05-07 19:22:06 UTC

Created attachment 171767 [details]
EMF sample with xform, exclip and ellipse

As per Bartosz request, to check rotation of ExcludeClipRect

Comment 6 Valek Filippov 2021-05-07 19:22:38 UTC

Created attachment 171768 [details]
Screenshot ofthe xform-exclip-ellipse opened in MS Paint

Comment 7 Valek Filippov 2021-05-24 15:13:41 UTC

Created attachment 172299 [details]
WMF sample with regular and inverted coords for ExcClipRect

As per Bartosz request

Comment 8 Valek Filippov 2021-05-24 15:15:53 UTC

Created attachment 172300 [details]
Screenshot of the WMF sample opened in MS Paint

Right ExcClipRect has inverted coords.

Comment 9 Bartosz 2021-05-25 10:47:40 UTC

For WMF it is regression, as it is not showing anything now.
For LO 6.4.7 it was ok (but inverted):

Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.1
CPU threads: 12; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Comment 10 Aron Budea 2022-04-22 00:46:08 UTC

(In reply to Bartosz from comment #9)
> For WMF it is regression, as it is not showing anything now.

The WMF regression started with the following commit, bibisected using repo bibisect-linux-64-7.1.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8deb9b3d2f8781628db73d3b2a3c7939ea4fcc2d
author		Bartosz Kosiorek <gang65@poczta.onet.pl>	2021-04-02 16:06:11 +0200
committer	Xisco Fauli <xiscofauli@libreoffice.org>	2021-04-06 14:04:15 +0200

tdf#37281 tdf#45820 tdf#48916 tdf#55058 EMF Implement complex clipping

Comment 11 Aron Budea 2022-04-22 00:47:13 UTC

(In reply to Aron Budea from comment #10)
> The WMF regression started with the following commit, bibisected using repo
> bibisect-linux-64-7.1.
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=8deb9b3d2f8781628db73d3b2a3c7939ea4fcc2d
Which is the backport of this commit from 7.2:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=aa17ea3d36b8f1ea8cd3d2fb215e80051547439d