| Summary: | New "Files > Properties > General > Location" link feature doesn't work on Windows | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Ming Hua <ming.v.hua> |
| Component: | UI | Assignee: | Heiko Tietze <heiko.tietze> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | buzea.bogdan, heiko.tietze, mikekaganski |
| Priority: | medium | ||
| Version: | 7.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=135896 | ||
| Whiteboard: | target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
Thank you for reporting the bug. I can confirm that the bug is present in 7.2.0.0.alpha0+ version Heiko, since you added this feature, would you please have a look? If you can't debug/fix because you are not familiar with Windows, would you at least disable this feature on Windows? Thanks. Mike, I suspect set_uri("file://" + aText); is not working on Windows. Any tip what's exactly wrong, maybe backslash?
(In reply to Heiko Tietze from comment #3) > Mike, I suspect set_uri("file://" + aText); is not working on Windows. Oh of course this is wrong on any platform, and may work on *nix just by chance, and not always. The proper way would be *converting* a system path to URL, e.g. using osl::FileBase::getFileURLFromSystemPath. Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a7be44be49ddc0a501f31f13e545a921a3dcc5c4 Resolves tdf#142041 - Hyperlink to file location It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Working well now. Verified in Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 08e99279226206db8ce83cdebc4cf2994739e90b CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded |
This new feature added in 7.2 doesn't work for me. Steps to reproduce: 1. Fresh profile, start LibreOffice and open an ODT file. 2. Menu File > Properties..., General tab in the pop-up dialog. 3. The folder containing the file is listed after "Location:", and is a clickable link. 4. Click it, an dialog with error messages pops up: (com.sun.star.lang.IllegalArgumentException) { { { Message = "XSystemShellExecute.execute, getSystemPathFromFileURL <file://C:\\Users\\Public\\Documents> failed with 21", Context = (com.sun.star.uno.XInterface) @0 } }, ArgumentPosition = (short) 0 } Expected result: No error message, the folder is opened in Windows file explorer. Version information: Daily build MSI installer downloaded from dev-builds.libreoffice.org on 2021-05-01: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded Also reproducible with English UI.