| Summary: | FILEOPEN XLSX Excel default time formats don’t match in Calc with Hungarian locale | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Calc | Assignee: | Eike Rathke <erack> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | 79045_79045, erack, nemeth, serval2412, varga.balazs3, xiscofauli |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=133672 https://bugs.documentfoundation.org/show_bug.cgi?id=140978 |
||
| Whiteboard: | target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107575 | ||
| Attachments: |
Example file from Excel
Screenshot of the original document side by side in Excel and Calc Example file from Writer with all default LO-supported time formats as fields The Writer reference file, just to avoid huge regressions |
||
|
Description
NISZ LibreOffice Team
2021-05-11 12:15:27 UTC
Created attachment 171879 [details]
Screenshot of the original document side by side in Excel and Calc
Created attachment 171880 [details]
Example file from Writer with all default LO-supported time formats as fields
Created attachment 171881 [details]
The Writer reference file, just to avoid huge regressions
Code pointer I suppose: i18npool/source/localedata/data/hu_HU.xml 50 <TimeAM>DE</TimeAM> 51 <TimePM>DU</TimePM> 282 <FormatElement msgid="TimeFormatskey2" default="true" type="medium" usage="TIME" formatindex="40"> 283 <FormatCode>HH:MM:SS</FormatCode> 284 </FormatElement> But I don't know if it can be changed only for xlsx/xls. Indeed, I can understand Excel can be seen as the reference for xlsx or xls but not for the other like ods files unless ods should also display the same? @Eike, I thought you might be interested in this issue We can easily change the AM/PM representation from "DE" to "de." and "DU" to "du."
If the default time formats are to be expected as not displaying leading 0 we can of course also change those to H:MM and H:MM:SS
For both, AM/PM and time formats, the current definitions are from 2005 and thus probably never had a review or were corrected, if they should have been.
Of course, changing them will affect all documents, not just .xls/.xlxs, unless formats are explicitly assigned differently.
Note that the first time format in the attached .xlsx is stored as
<numFmt numFmtId="165" formatCode="[$-F400]h:mm:ss\ AM/PM"/>
with the [$-F400] meaning display in whatever system default time format you have.
There were no objections so I went ahead with https://gerrit.libreoffice.org/c/core/+/116713 cast your veto there ;) It was unclear to me whether the default date+time format should also be changed to display no leading 0, so from YY-MM-DD HH:MM to YY-MM-DD H:MM That can be added if wanted. No responses or objections => I'll merge that change as is. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8e7a9b0243a4a63841d1cb1faba118274d574053 Resolves: tdf#142216 Fix {hu-HU} AM/PM words, default time without leading 0 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3964e0854507b2696ae0fbe48a4fb005c779947e CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win Locale: en-DK (hu_HU); UI: en-GB Calc: threaded |