| Summary: | Use binary image format 0x13 only when necessary, to allow compatibility with other suites | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
| Component: | BASIC | Assignee: | Andreas Heinisch <andreas.heinisch> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | himajin100000, mentoring, starun.1998 |
| Priority: | medium | Keywords: | difficultyInteresting, easyHack, skillCpp |
| Version: | 5.0.3.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bz.apache.org/ooo/show_bug.cgi?id=64377 https://bugs.documentfoundation.org/show_bug.cgi?id=92620 https://bugs.documentfoundation.org/show_bug.cgi?id=94617 https://bugs.documentfoundation.org/show_bug.cgi?id=142405 |
||
| Whiteboard: | target:7.6.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107659 | ||
| Attachments: |
Test file from i#64377
Test file with password on macro |
||
|
Description
Mike Kaganski
2021-05-20 09:46:49 UTC
Created attachment 172193 [details]
Test file from i#64377
Steps for testing:
1. Open the attached document in LibreOffice >= 5.2; allow macros
2. In Basic IDE, Tools->Select Module
3. On Libraries tab, choose "test-ray-bigmodule.odt" in Location drop-down list
4. Select Xray library, click on Password button, set some password -> OK
5. Close the dialog and IDE
6. Save the document (accept the warning telling about module _Main, which is too large to store in binary format by pressing OK).
7. Reopen the document, check that pressing Button starts Xray; check that Xray module is password-protected.
8. Try to do the same in LibreOffice 5.1, or in AOO (the button does not work).
(In reply to Mike Kaganski from comment #1) > 8. Try to do the same in LibreOffice 5.1, or in AOO (the button does not > work). Sorry, a thinko: LibreOffice before 5.0.3 was meant (so e.g., LibreOffice 5.0.2 or 4.4). I was looking to work on this issue and was following the steps you mentioned and > Save the document (accept the warning telling about module _Main, which is too large to store in binary format by pressing OK) But i didn't got this error message on saving the document. > 1. Open the attached document in LibreOffice >= 5.2; I'm using 7.2 Libreoffice (In reply to Tarun Sharma from comment #3) > But i didn't got this error message on saving the document. Which would mean that you didn't set the password, as mentioned in step 4 of comment 1. If you are sure you have followed all steps carefully, then please attach the resulting file. Created attachment 173302 [details]
Test file with password on macro
attachment 173302 [details] Yes i have followed every step and didn't got the warning. Tried for the second time also. https://imgur.com/a/wKcMSMN . <- Here I'm getting old password enabled as i have set a password. Also ii'm attaching the file. (In reply to Tarun Sharma from comment #6) > Yes i have followed every step and didn't got the warning. Tried for the > second time also. No you didn't :-D > https://imgur.com/a/wKcMSMN . <- Here I'm getting old password enabled as i > have set a password. Also ii'm attaching the file. Yes, and the screenshot shows exactly where you didn't follow the steps: comment 1 step 3. Okk, yess sorry got the warning didn;t select xray from the dropdown. Hi Maybe a noob question but I was looking in to the proposal and i was kinda stuck on binary format 0x12 or 0x13. Is it like (in binary 19 ) it has 19 bit for 0x13 ? What does it represent/ ? (In reply to Tarun Sharma from comment #9) I'm sorry, I don't quite understand the question. What "in binary 19" means? "it has 19 bit for 0x13" - what is "it", what "19 bit" are meant? 0x13 is indeed decimal 19, but I fail to see other relation of the mentioned numbers. "What does it represent/ ?" - what is "it" in the question? I suspect you ask about the number in the version - then it should be described in basic/source/inc/filefmt.hxx, which is mentioned in comment 0... sorry for bad phrasing of the question. i wanted to know what is binary format 0x13 ? (In reply to Tarun Sharma from comment #11) That is the number of the binary image version, described in basic/source/inc/filefmt.hxx. Hi Mike I wasn't able to understand from the attached links that how to resolve this issue. I reverted the changes in sbxmod.cxx, like it was before the introduction of 0x13 https://git.libreoffice.org/core/+/ddb45261590939d884ac2bcb1fd258de7b2370da but still was getting the warning in xRay. Can i get more help in this!? *** Bug 142405 has been marked as a duplicate of this bug. *** Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d622972dceba40d89852b1dc832c6e2a4612b2fa tdf#142391 - Store method using 0x13 format only when actually needed It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #15) Thanks Andreas! FTR: with this commit, we factually disabled writing pre-0x12 images, i.e. OOo prior to v.2.2 will not be able to use the binary images saved by LibreOffice. Likely, it's not goint to upset lots of people :) |