| Summary: | Dropdown in Navigator deck hidden behind scroll bar with panel at default size | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | minor | CC: | caolan.mcnamara, heiko.tietze, ilmari.lauhakangas, m.weghorn, vsfoote |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.2.0.0 alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.3.0 target:7.2.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103030 | ||
| Attachments: | Screenshot | ||
|
Description
Telesto
2021-05-24 09:54:52 UTC
Created attachment 172286 [details]
Screenshot
No issue with Version: 7.0.0.0.beta1+ (x64) Build ID: 2891e91a513520d68ea2b8c59c14335861a15253 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL But that as fixed minimum width In 4.4.7.2 it was free, and also working properly. So it's surely a regression. But probably more consternation of things.. say making the sidebar panel size unfixed + welding no repro in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c5ca46e75e28ba4245d8544ca53c71fea87d1bbd CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL Still present Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3d18cae102e16b85fb8787f5ec3b086bfa2bd7b8 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: threaded 1. Open Writer (stock settings) or Safe-mode 2. Open the sidebar styles deck 3. Notice a scrollbar overlapping the drop down The default size of the navigator panels appear to be little to small by default (on Windows; didn't check other systems) Reproduced with Navigator deck Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded Jumbo Duplicates bug 143646 (or vice versa). Apparently the margins are ignored and we could add some pixels to the minimum size. Bibisected with linux-64-7.2 https://git.libreoffice.org/core/commit/f9cf66b39ea00afc66ae79ca46cd9071f3598cb8 weld the sidebar deck Adding Cc: to Caolán McNamara Launched always in safe mode. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0b16224062c0434087c3b904cc57d44e5723394b tdf#142458 minimal width not including extra width needed by scrolledwindow It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. backport to 7-2 in gerrit Now it's working with gtk3 and gen, but not with kf5 Arch Linux 64-bit Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 2cfcc8d7c988631333998a78b4b40cb17b025fe7 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 1 September 2021 I didn't check yet it this is relevant, but if you're switching between backends then you may have to remove your config between runs and/or manually drag it to the right to get it to snap to the new min size since the last saved-to-config size) (In reply to Caolán McNamara from comment #12) > I didn't check yet it this is relevant, but if you're switching between > backends then you may have to remove your config between runs and/or > manually drag it to the right to get it to snap to the new min size since > the last saved-to-config size) Forgot to mention I was using safe mode. However, it does not snap into a minimum size that would keep the dropdown visible under kf5 Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/95b3e2a0a4407a3e09efbacef5987ff6d69bc400 tdf#142458 minimal width not including extra width needed by scrolledwindow It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. hmm, kf5 is fall foul of https://cgit.freedesktop.org/libreoffice/core/commit/?id=f39f21d92ec83c3a5062f29dd26214fc83012c06 which changes m_nBorderWidth during Paint which is unfortunate https://gerrit.libreoffice.org/c/core/+/121615 is my current thing wrt that (In reply to Caolán McNamara from comment #16) > https://gerrit.libreoffice.org/c/core/+/121615 is my current thing wrt that I verify it snaps to the minimum with this! Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b9a3ab00dfe64c7bb19277dbad3545b83aacdc21 tdf#142458 Set correct ScrolledWindow BorderWidth in the ctor It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Confirmed fixed, h-scroll bar does not appear for any content panel at its packing minimum width. But, if the "minimumwidth" stanza in Expert configuration is set false, the h-scroll bar will appear as needed. Unfortunately on appearing the h-scroll bar is positioned over the droplists, or toolbar (for Gallery deck), at the bottom of the SB deck. Showing the h-scroll bar should probably reduced the height of the content panel in the deck to allow vertical space. Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: bc7baa18435000f47f90e47d3300710bcb4cf56b CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/99141aea4d81d89ff5d14087e6647b25f7018e8b Related: tdf#142458 don't change border size during Paint It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/71968455be0e696423011775b957d5b738b9f457 tdf#142458 Set correct ScrolledWindow BorderWidth in the ctor It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |