| Summary: | [CRASH] searching on slide notes will crash Impress | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Marina Latini (SUSE) <marina.latini> |
| Component: | Impress | Assignee: | Tomaz Vajngerl <quikee> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | gerald, mmachova, quikee, serval2412, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 7.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugzilla.suse.com/show_bug.cgi?id=1185797 | ||
| Whiteboard: | target:7.2.0 target:7.1.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
bt with debug symbols
Valgrind trace |
||
|
Description
Marina Latini (SUSE)
2021-05-25 10:09:26 UTC
adding Tomaž Vajngerl in CC due to https://git.libreoffice.org/core/+/2ebc26aeefefe33ee6180862509e4971ff2dfc6f Reproduced in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 49af7e22e61c2e5d440ad55cd362388983e128ae CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Steps to reproduce: 1. Open Impress 2. Type 'hello' 3. Go to View - Notes 4- Search 'hello' 5. Click on find all it seems this problem is only reproducible searching on the notes view. Lowering priority a bit (In reply to Xisco Faulí from comment #3) > it seems this problem is only reproducible searching on the notes view. > Lowering priority a bit My original case was searching in the slides, and then simply going "next" (or button down), "next",... and see it crash. Same in another document yesterday. In neither case did I even have the notes view open (or was aware there were notes to begin with). Does that warrant increasing priority again? (In reply to Xisco Faulí from comment #3) > it seems this problem is only reproducible searching on the notes view. it depends. the problem is that in case of large presentations, if the word searched is both on slides content and notes LibreOffice will crash and the general user can't understand why. The problem happens when indeed the word searched is in the notes but for this case I spent quite some time in cleaning up the first internal document (51 slides) trying to understand the origin of the issue. I agree that you need to be in the unlucky condition to search for a word that is also available from the notes, but, TBH, if you are using notes in a presentation, the probability to have a word both on slides and notes it's quite high. Created attachment 172333 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today + gtk3 rendering, I could reproduce this by using Xisco's comment.
Created attachment 172337 [details]
Valgrind trace
Tomaz: could you please take a look? Thanks. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3b75f9add7ed80e803b0771d86892d6ca0f47e71 tdf#142478 fix crash when searching and a viewshell change occurs It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7f059ce157da0de40a98f63f61d923cc67d93884 tdf#142478 add test that triggers find all and crashes It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/db6efbaf5f9d6ae818afccec6a9fab219268b621 tdf#142478 fix crash when searching and a viewshell change occurs It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I verified that the crash appears to be fixed with both Version: 7.1.5.0.0+ / LibreOffice Community Build ID: db6efbaf5f9d6ae818afccec6a9fab219268b621 CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-1, Time: 2021-06-07_20:32:23 and Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: b6a30a9db00f92eec7387a577321d65d47ff4af5 CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-08_21:15:20 (Searching is still a bit strange when a word appears on the slide and the notes in that one needs to hit "Next" to move from slide to notes or vice versa and than again to actually go to the actual hit.) (In reply to Gerald Pfeifer from comment #12) > (Searching is still a bit strange when a word appears on the slide and > the notes in that one needs to hit "Next" to move from slide to notes or > vice versa and than again to actually go to the actual hit.) That should've been fixed too.. at least it is when I test it with my documents |