Bug 142510

Summary:	Extra frame around sidebar on macOS
Product:	LibreOffice	Reporter:	Thorsten Wagner <thorsten.wagner.4>
Component:	UI	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	caolan.mcnamara, heiko.tietze, ilmari.lauhakangas, lo, quikee
Priority:	medium	Keywords:	bisected
Version:	7.2.0.0 alpha1+
Hardware:	All
OS:	macOS (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=125508
Whiteboard:
Crash report or crash signature:		Regression By:
Attachments:	Screenshot

Description Thorsten Wagner 2021-05-26 20:09:36 UTC

Description:
Black frame lines are drawn around sidebar (see screenshot for an example). This does not look compliant to macOS UI theme at least. Issue is a follow up from tdf#125508.

Issue is not existing in current LO releases but in current revision from master.

Steps to Reproduce:
1. Open Writer, Calc, Impress, or Draw
2. Look at the sidebar

Actual Results:
Black frame lines around sidebar

Expected Results:
No frame lines around sidebar


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: d79b3317d267ffc13da05d08239dd7c8754468b6
CPU threads: 8; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded

Comment 1 Thorsten Wagner 2021-05-26 20:10:30 UTC

Created attachment 172374 [details]
Screenshot

Comment 2 Heiko Tietze 2021-05-27 09:08:15 UTC

Confirming, quite ugly on macOS but no issue with kf5. I wonder if this is fall-out from bug 133690. Tomaz, any idea?

Comment 3 Thorsten Wagner 2021-09-24 20:57:39 UTC

Issue has disappeared with current revision from master. It would be very nice to get a backport to LO 7.2.

Comment 4 psidiumcode 2021-10-11 18:44:06 UTC

Bisected from bibisect-mac64-7.3.
 9ab2af44c9d938e19afcb6623f6bb60dc77792d4 is the first fixed commit
commit 9ab2af44c9d938e19afcb6623f6bb60dc77792d4
Author: libreoffice <libreoffice@libreoffices-Mac-mini.local>
Date:   Wed Sep 22 14:14:31 2021 +0200

    source dedb3337291c09c85262ca08bacd01e8e5901d22
    
    source dedb3337291c09c85262ca08bacd01e8e5901d22

 LibreOffice.app/Contents/Frameworks/libvcllo.dylib | Bin 12247524 -> 12247524 bytes
 .../Contents/Resources/config/images_breeze.zip    | Bin 1897836 -> 1897836 bytes
 .../Resources/config/images_breeze_dark.zip        | Bin 1893737 -> 1893737 bytes
 .../Resources/config/images_breeze_dark_svg.zip    | Bin 1575118 -> 1575118 bytes
 .../Resources/config/images_breeze_svg.zip         | Bin 1572644 -> 1572644 bytes
 .../Contents/Resources/config/images_colibre.zip   | Bin 2787272 -> 2787272 bytes
 .../Resources/config/images_colibre_svg.zip        | Bin 2904542 -> 2904542 bytes
 .../Resources/config/images_elementary.zip         | Bin 4206066 -> 4206066 bytes
 .../Resources/config/images_elementary_svg.zip     | Bin 5530487 -> 5530487 bytes
 .../Resources/config/images_karasa_jaga.zip        | Bin 4892474 -> 4892474 bytes
 .../Resources/config/images_karasa_jaga_svg.zip    | Bin 19326490 -> 19326490 bytes
 .../Contents/Resources/config/images_sifr.zip      | Bin 2114075 -> 2114075 bytes
 .../Contents/Resources/config/images_sifr_dark.zip | Bin 2116013 -> 2116013 bytes
 .../Resources/config/images_sifr_dark_svg.zip      | Bin 1765493 -> 1765493 bytes
 .../Contents/Resources/config/images_sifr_svg.zip  | Bin 1761603 -> 1761603 bytes
 .../Contents/Resources/config/images_sukapura.zip  | Bin 3050955 -> 3050955 bytes
 .../Resources/config/images_sukapura_svg.zip       | Bin 4370295 -> 4370295 bytes
 LibreOffice.app/Contents/Resources/setuprc         |   2 +-
 LibreOffice.app/Contents/Resources/versionrc       |   2 +-
 19 files changed, 2 insertions(+), 2 deletions(-)

It looks like it got fixed in this commit:
https://git.libreoffice.org/core/+/dedb3337291c09c85262ca08bacd01e8e5901d22

Comment 5 Buovjaga 2021-10-13 10:09:09 UTC

Thanks for the bibisect. It has already been backported to 7.2

*** This bug has been marked as a duplicate of bug 143487 ***