| Summary: | Poor contrast on spellcheck in Linux dark mode | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Tim Chambers <tim.chambers1968> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | aron.budea, buzea.bogdan, caolan.mcnamara, f.thaler, grishka, med.medin.2014, telesto, ville.aakko |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 6.3.6.2 release | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.5.0 target:7.4.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 109527, 143344 | ||
| Attachments: |
Screenshot
Screenshot - of the problem persisting screenshot from Version: 7.4.3.2 |
||
|
Description
Tim Chambers
2021-06-03 07:05:06 UTC
Created attachment 172588 [details]
Screenshot
Illustration of the issue
Suggested fix - the text colour and background for sample text and suggestions in the spellcheck window should match the document settings. *** Bug 143060 has been marked as a duplicate of this bug. *** *** Bug 143330 has been marked as a duplicate of this bug. *** Can confirm, this is an issue. *** Bug 150415 has been marked as a duplicate of this bug. *** Bibisected with 6.3 repo: author Caolán McNamara <caolanm@redhat.com> 2019-06-14 commit 243b5b392906042ab03800e0b5765e6f3513372c weld SpellDialog and now magical CC well, I can make the background the "document background" color which is what the dialog seems to assume is the case Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2ea790200f5d915f88c6f78014d978ce8d91e33f tdf#142631 use document background color in the spelling widget It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. backport to 7-4 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/61dae407d98d07a67e4eda63415cc8588e13c91d tdf#142631 use document background color in the spelling widget It will be available in 7.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. It's ok now in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: e46f9cc4b506c325cbe1060777bbc81fd1630f49 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Was not ok in Version: 7.4.0.2 / LibreOffice Community Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded *** Bug 133306 has been marked as a duplicate of this bug. *** *** Bug 131978 has been marked as a duplicate of this bug. *** Created attachment 184414 [details]
Screenshot - of the problem persisting
Is this really fixed? Just now I downloaded and ran LO, on Linux Mint 21.1 Cinnamon, and I saw the attached. Note the colour of the words 'hello there'. Those words are not very readable, are they? (In reply to nicholasjoll from comment #16) > Is this really fixed? Just now I downloaded and ran LO, on Linux Mint 21.1 > Cinnamon, and I saw the attached. > > Note the colour of the words 'hello there'. Those words are not very > readable, are they? 7.5 will be released in February 2023. It's tested now in order to be released on time. 7.4.2 was released on 13 October 2022. Go to Help - About. If you have 7.4.2 version but you don't see the changes go to Help - Restart in Safe Mode - Factory settings and check that two options and restart. Everything should be fine. If not please come back with feedback. It is not fixed in Version: 7.4.3.2 / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded But it is fixed in Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Caolan, in both cases I restart to Help - Restart in Safe mode - Factory settings - and I changed in Tools - Options - LibreOffice - Application Color - LibreOffice Dark. Something have to be changed in code OR we should remove 7.4.2 target. Created attachment 184416 [details]
screenshot from Version: 7.4.3.2
A missing part in 7.4 which is present in 7.5 is likely that of https://bugs.documentfoundation.org/show_bug.cgi?id=116566 which I've not cherry-picked for consideration for inclusion into 7-4 as https://gerrit.libreoffice.org/c/core/+/144910 |