| Summary: | LO72a1/b1: The Bullets and Numbering in Impress has unlocalizable Reset button | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Martin Srebotnjak <miles> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, ming.v.hua, serval2412 |
| Priority: | medium | ||
| Version: | 7.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.2.0.0.beta2 target:7.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 114068 | ||
| Attachments: | Reset button (bottom) in Impress | ||
|
Description
Martin Srebotnjak
2021-06-15 10:20:31 UTC
Created attachment 172902 [details]
Reset button (bottom) in Impress
See for yourself.
Please fix ASAP, before LO72RC1.
Reproduced in (slightly old) master: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded Code pointer: https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/bulletandposition.ui?r=95e986d6#105 Looks like a simple missing translatable="yes" tag. Good catch Ming! Caolán: when I do git grep -n -2 'GtkButton" id="reset"', I noticed 2 kinds of case: 1) <property name="label" translatable="yes" context="stock">_Reset</property> 2) <property name="label" translatable="yes" context="bulletsandnumbering|reset">Reset</property> I suppose 1) should be applied here since we got <property name="label" translatable="yes" context="stock">_OK</property> in the file quoted by Ming. I thought Caolan is going to congratulate me for reporting it, not Ming :) This seems to have gone wrong with commit 15664117ef4db51bdcabb46b7990573509da0d73 Author: Gülşah Köse <gulsah.kose@collabora.com> Date: Thu Jul 25 21:40:48 2019 +0300 tdf#125923 Fix reset button. either 1 or 2 would work, 1 is probably better in requiring zero additional translation work seeing a stock Reset translations are already available Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/4d26716bb562808d9a30b483157ab63cbb4636f8 Resolves: tdf#142874 missing translation property It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2305f8fcf69b35f2d2e68eb20172af13ce0792d2 Resolves: tdf#142874 missing translation property It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |