| Summary: | Crash when pasting cells with comments and "skip empty cells" option selected | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Ming Hua <ming.v.hua> |
| Component: | Calc | Assignee: | Julien Nabet <serval2412> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | noelgrandin, serval2412, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 7.1.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://crashreport.libreoffice.org/stats/signature/ScColumn::DeleteBeforeCopyFromClip(sc::CopyFromClipContext%20&,ScColumn%20const%20&,sc::ColumnSpanSet%20&) | ||
| Whiteboard: | target:7.3.0 target:7.2.0.0.beta2 target:7.1.5 | ||
| Crash report or crash signature: | ["ScColumn::DeleteBeforeCopyFromClip(sc::CopyFromClipContext &,ScColumn const &,sc::ColumnSpanSet &)"] | Regression By: | |
| Attachments: |
Sample file that helps trigger the crash
gdb bt |
||
|
Description
Ming Hua
2021-06-18 14:06:09 UTC
I can't reproduce it in Version: 7.2.0.0.beta1+ / LibreOffice Community Build ID: d376297c643785564e7bda1a74b573c35ade6cb8 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded I believe you have to copy after step 2, isn't it ? (In reply to Xisco Faulí from comment #1) > I believe you have to copy after step 2, isn't it ? Yes of course. I used shortcut Ctrl+C to copy. Created attachment 173011 [details]
gdb bt
On pc Debian x86-64 with master sources updated today + gen rendering, I could reproduce this.
I gave a try with https://gerrit.libreoffice.org/c/core/+/117497 Forgot my previous comment, i can reproduce it in Version: 7.2.0.0.beta1+ / LibreOffice Community Build ID: d376297c643785564e7bda1a74b573c35ade6cb8 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=afad9ccb381a02b90654a5fa302480e46f38a1fc author Noel Grandin <noel.grandin@collabora.co.uk> 2019-12-12 16:49:19 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2019-12-13 07:04:49 +0100 commit afad9ccb381a02b90654a5fa302480e46f38a1fc (patch) tree 805e39b189c25d8dbd8ab932baca0fc0d7482d06 parent d755b2d4a3340f42a90d15d4795cc947a0b18e4a (diff) sc: rowcol: tdf#50916 pass ScDocument* around in data/ Bisected with bibisect-linux64-7.0 Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a6d269ed9478b20f611912bf9711c2683e7bc924 tdf#142932: fix crash when pasting cells with comments+"skip empty cells" It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/bb59b4165456d13eda800098be8b875d93b093d3 tdf#142932: fix crash when pasting cells with comments+"skip empty cells" It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Cherry-pick for 7.1 branch waiting for review here: https://gerrit.libreoffice.org/c/core/+/117637 Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/0a8131d098e24842480c9c42b5e47accc7c59ce0 tdf#142932: fix crash when pasting cells with comments+"skip empty cells" It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Confirmed with 7.1.5 RC1: Version: 7.1.5.1 (x64) / LibreOffice Community Build ID: 2ca94649fd6dbdcab938c55c28b6a950a9634a34 CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded Thanks for the quick fix, Julien! |