Bug 143037

Summary:	Relative size setting overwritten only after closing dialog when image size changed in the Crop tab (see comment 3)
Product:	LibreOffice	Reporter:	Konstantin <oobugs>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	buzea.bogdan, heiko.tietze, rb.henschel, stephane.guillou, telesto
Priority:	medium
Version:	Inherited From OOo
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=143324
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103152, 108280

Description Konstantin 2021-06-24 07:56:07 UTC

Description:
Some Settings on an images' settings windows are lost even after clicking OK.

Steps to Reproduce:
1.Open new Writer Document
2.Insert -> Image
3.Right click -> Settings
4.Select Checkbox "relative to" on the Type pane
5.switch to Cut pane
6.change image size
7.switch back to type, to see that checkbox is still clicked.
8.Click OK to close settings.
9.right click on image -> settings
10 see, that the checkbox is no longer clicked.

Actual Results:
see above, setting is lost.

Expected Results:
The checkbox should stay clicked, after clicking OK on the settings window. At least an info, why something is reset would be needed.


Reproducible: Always


User Profile Reset: No



Additional Info:
Maybe other combinations of actions also lead to loss of settings. I didn't check.

I didn't try to reset my user profile, but on another user account on a Linux pc, the same behaviour happens.

Version: 7.0.6.2 (x64)
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Comment 1 Stéphane Guillou (stragu) 2021-06-24 13:37:34 UTC Comment hidden (obsolete)

I can see what is described in :

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: e3086b58eb5427d520b86c185f9d911bb6f7a3a0
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-21_15:37:11
Calc: threaded

If someone defines a new size using measuring units, it makes sense that the relative size setting is turned off automatically. But that should happen directly when setting the value, not when the dialogue is closed and reopened, in my opinion.

Makes me wonder why there is a Size and Scale setting in the Crop tab in the first place?
To me, it would make sense to only have it in one place. Probably:
- Size and Scale in the Type tab (maybe with a different tab name? "Size and Position"?)
- Crop tab should be only about cropping.

Comment 2 BogdanB 2023-05-15 18:31:27 UTC

Stephane, please, can you improve a little bit the bug title? It's hard to test a Cut Pane, etc. Also, if the steps can be simplified. Thanks.

Comment 3 Stéphane Guillou (stragu) 2023-05-17 15:36:56 UTC

Steps for what the OP describes:

1. Open Writer, insert image
2. Insert an image
2. Right-click on image > Properties... > Position and Size, activate "Relative to Entire paragraph area" for width
3. Go to Crop tab, change the width in "Image Size"
4. Back in "Position and Size" tab, see that Relative option is still active
5. Click OK; see image width changed
6. Right-click > Properties... > Position and Size

Result: Relative setting off, overwritten.

But I think the overarching issue here is how the fields sync inconsistently in the Crop tab (and beyond), since OOo 3.3 times.

Currently, changing values in the "Crop" section:
- updates the values in the "Image Size" section if "Keep scale" is used; or
- updates the values in the "Scale" section if "Keep image size" is used.

So far, so good: my logical interpretation of the two bottom sections is "the size of the crop area with different units", i.e. another method to define the cropping area.
However, as soon as you touch the values in the "Image Size" or "Scale" sections, the values are not synced anymore with the "Crop" section, and are only used to stretch or shrink the image accordingly. This is unexpected: it goes against the selected "Keep scale / Keep image size" setting, has no effect on cropping, and is a duplication of the "Position and Size" tab.
Furthermore, changing those bottom values does not update the preview whatsoever.

I think there is too much complexity in this tab, and that we should either:
A. improve it by properly syncing the values across sections + making the preview always update, including with the stretching of the image; or
B. simplify it by removing the two bottom sections and the "original size" button. (The preview would ideally still need to update for when the image size is preserved, i.e. shrinking / stretching the image)

UX team, what are your thoughts?

Comment 4 Heiko Tietze 2023-05-22 09:11:14 UTC

The "relative" option is just a different way to define the image size. OTOH, I'd expect the 100% to change the absolute size when changing from portrait to landscape. The expectation to remember this value is valid.

Position & Size and Scaling are entangled, which is odd. I think it's a convenient feature to have (absolute) image size and (relative) scale values available. However, it needs to be applied when switching from crop to pos & size. And in this case you cannot expect a relative size to the page anymore.

Either we fix the issue and apply the scale/size values from crop to p&s and vice versa (with or without taking care of the relative setting) or remove the scale/size controls from the crop tab - which would be my preference.

The issue has been reported before in bug 149566 - Scale picture beyond page boundaries and has a lot of related topics such as bug 135832 - UI: Configuring a bitmap to show on full page with custom position and size not easy to do/ user friendly or bug 106934 - Image Control property style:repeat="scale" is not valid.