| Summary: | Selecting the None slide transition has no effect | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | rogern <rnbzilla> |
| Component: | Impress | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | caolan.mcnamara, serval2412 |
| Priority: | high | Keywords: | bibisectRequest, regression |
| Version: | 7.1.4.2 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.3.0 target:7.2.0.2 target:7.1.6 target:7.1.5 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
rogern
2021-07-10 10:12:27 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this. Regression due to https://cgit.freedesktop.org/libreoffice/core/commit/?id=e2970060121824650f95421d8d2411840a40311f author Caolán McNamara <caolanm@redhat.com> 2021-05-27 20:37:50 +0100 committer Caolán McNamara <caolanm@redhat.com> 2021-05-28 09:46:22 +0200 commit e2970060121824650f95421d8d2411840a40311f (patch) tree b798a38803832d47433f1cf76679def63e68b79b parent 164fecadfde2569cb5324017d9bf22e2963008b3 (diff) tdf#142150 nothing already selected on MouseUp without previous MouseDown if mouse down was on tooltip (possible on macOS) Caolán: I saw that this commit was already to fix another regression. Thought you might have some idea here. Detailed step by step process to reproduce this:
- Launch Impress
- click F11 to make the sidebar appear if it's not present
- click the seventh icon "Slide Transition"
=> Slide Transition appears with "None", "Wipe", "Wheel", etc. (each row contains 3 icons) 12 rows with 3 icons each
- click "Wipe" icon
=> a preview of Wipe appears and at left, the thumbnail of the slide has a small icon to indicated the slide has now a transition
- click "None"
=> the small icon doesn't disappear (and the transition isn't removed).
I don't reproduce this with LO 7.0.4.2 Debian package.
This allows to add the "No selection" image.
446 // dummy list box of slide transitions for startup.
447 mxVS_TRANSITION_ICONS->InsertItem(
448 0, Image( StockImage::Yes, "sd/cmd/transition-none.png" ),
449 SdResId( STR_SLIDETRANSITION_NONE ),
450 VALUESET_APPEND, /* show legend */ true );
451 mxVS_TRANSITION_ICONS->Recalculate();
Its trying to use an itemid of 0 which valuesets aren't supposed to allow and then seems to try to equate "nothing selected" as equivalent to the "none" item selected. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/57980fa601a868e50d6afd0ca5b5c2f15eeb9539 tdf#143291 the "none" item selected is distinct from nothing selected It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. backports to 7-2, 7-1 and 7-1-5 in gerrit After having tested again with the patch, I confirm it works again now! Thank you Caolán! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/f91ffe03e035cff1204de230ec78fc0aa1bdbb36 tdf#143291 the "none" item selected is distinct from nothing selected It will be available in 7.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/c5dfab1aca06ff52345186cd4bcf42677598c91f tdf#143291 the "none" item selected is distinct from nothing selected It will be available in 7.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1-5": https://git.libreoffice.org/core/commit/312f9e1339d7925614a59ab08f0e65d2b5a9d87d tdf#143291 the "none" item selected is distinct from nothing selected It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Version: 7.1.4.2 (x64) / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded FYI, There is an additional side-effect: when inserting a new slide in the sidebar or slide sorter view, the new slide inherits the slide transition of the immediately preceeding slide or in the case of inserting before slide 1 the new slide inherits the transition of slide 1. This means that if you have a presentation where all slides have transitions you cannot insert a new slide WITHOUT a transition. Oops. Workaround: File->New->Presentation a dummy preso then copy/paste a non-transition slide from the dummy preso to the afflicted preso. Regards. |