| Summary: | FILEOPEN DOCX Drag and drop change tracked move of table in Word imported incorrectly | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | nemeth, varga.balazs3 |
| Priority: | medium | Keywords: | filter:docx |
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=143510 | ||
| Whiteboard: | target:7.3.0 target:7.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 115709, 139532, 143035 | ||
| Attachments: |
The example file with the tables created in MS Word
Screenshot of the document with the tables side by side in Writer and Word Unit test document with tracked insertion of plain (not floating) table Minimal reproducer containing only a table wrap change The floating table in Word |
||
|
Description
NISZ LibreOffice Team
2021-07-12 15:23:55 UTC
Created attachment 173512 [details]
Screenshot of the document with the tables side by side in Writer and Word
Created attachment 173794 [details]
Unit test document with tracked insertion of plain (not floating) table
The previous test document contains two problems: not only lost tracked table (row) deletions and insertions, but conversion to floating table (with missing redline). That would be fine to file in a new bug.
Created attachment 173795 [details]
Minimal reproducer containing only a table wrap change
This is an example file for the wrap change, making the table "floating" in Word.
Created attachment 173797 [details]
The floating table in Word
Word can change track making a table floating.
Writer cannot handle this at all, that would be another half of this bug.
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/afc0c718ec9ca6a4fbe1324f68eb292d9a67b058 tdf#143318 DOCX import: fix missing redlines in flying tables It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. tdf#143318 DOCX import: fix missing redlines in flying tables makeRedline() exceptions (in the case of already existing redlines) skip the creation of the next (not existing yet) redlines in tables inside fly frames. Here: a tracked table moving revealed the problem, with the missing rejection of the new position, i.e. the "new" (second) table of the document. Note: fix also collecting redlines within tables: IsInTable() isn't true in the first cell of the table, losing the redline here, so it's replaced with m_nTableDepth > 0. Follow-up to commit 7f3c0bbc174b9b0316991c174ca3b407c0e3d141 "tdf#143510 DOCX import: fix tracked table drag & drop". László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/5af699be26fc959aa7d807e59d3873cc5b2fb230 tdf#143318 DOCX import: fix missing redlines in flying tables It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d5ade739771ddf06cc7ee6d4af15672bfcf09ed6 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: threaded |