Bug 143327

Summary:	UX issues with hex color input
Product:	LibreOffice	Reporter:	Aron Budea <aron.budea>
Component:	LibreOffice	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	minor	CC:	caolan.mcnamara, vsfoote
Priority:	medium
Version:	6.3.0.4 release
Hardware:	All
OS:	All
Whiteboard:	target:7.3.0 target:7.2.0.2
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	113223

Description Aron Budea 2021-07-13 01:43:33 UTC

Open eg. a document, then Format -> Page Style..., switch to Area tab, choose Color, and check the Hex field.

The field is in overwrite mode since bug 123291's fix.

Note fhe following issues:

1. Selecting the whole content, and typing one hexa character puts caret over the 1st character (and the next entry will overwrite it), while it should be over the 2nd, since you just typed the first character.

2. Pressing Backspace / Delete moves caret back to the 1st character. It should either move back one character in case of backspace, or stay where it is in case of delete.

Observed in LO 7.3.0.0.alpha0+ (eac5977bfc11797eda356560a5e45c51108ef5a1), 6.3.0.4 / Ubuntu.

Comment 1 V Stuart Foote 2021-07-13 14:03:29 UTC

Yes, there is a disconnect between cursor focus entering the field and the value(s) being parsed into the RGB.  RGB value per HEX pair should change as each valid pair is finalized--it seems to loose track of the HEX pairs in the overwrite mode.

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1db375e06516d0532f01f9585986617aa3079866
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Comment 2 Commit Notification 2021-07-15 12:52:24 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2cd936a882418b6babd8f37a83077e1bab5fb934

tdf#143327 keep selection bounds on replacing color

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Caolán McNamara 2021-07-15 12:53:39 UTC

fixes 1 IMO and makes 2 behave somewhat sanely I believe

Comment 4 Commit Notification 2021-07-16 15:07:43 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/cf12ce9224c2f4142e777a5c65a04e48b1bab0a6

tdf#143327 keep selection bounds on replacing color

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.