Bug 143831

Summary: EDITING Black background for spell checking underline on Windows GDI
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: WriterAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: normal CC: katyalukkarewa, merttumer, nemeth, telesto, varga.balazs3
Priority: medium Keywords: bibisected, bisected, regression
Version: 7.3.0.0 alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:7.3.0
Crash report or crash signature: Regression By:
Attachments: Example file from Writer
Screenshot of the problem in Writer

Description NISZ LibreOffice Team 2021-08-12 07:43:04 UTC
Created attachment 174219 [details]
Example file from Writer

Attached file contains some lorem ipsum text with English document language. 
With Windows GDI rendering the spell checkers red underlines have a black background instead of a transparent one.
Does not happen with Skia.

Steps to reproduce:
    1. Turn off Skia rendering on Windows, restart.
    2. Open attached file. Make sure to have English spell checking installed (or change the document language to one for which you have dictionaries).

Actual results:
Spell checking red squiggly underlines have black background.

Expected results:
Red underlines should have transparent background.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d1f1f546b212ecd651146addeb328806bb270d5f
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Additional Information:

Bibisected using bibisect-win64-7.3 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0759191e6923945469bc426b2c322ddeade12e09 
author 	merttumer <mert.tumer@collabora.com>	2021-06-16 21:04:33 +0300
committer	Mert Tumer <mert.tumer@collabora.com>	2021-07-07 08:05:58 +0200
commit 0759191e6923945469bc426b2c322ddeade12e09 (patch)

Cache a static wavy line as bitmap and reuse it

Adding CC to: Mert Tumer
Comment 1 NISZ LibreOffice Team 2021-08-12 07:43:21 UTC
Created attachment 174220 [details]
Screenshot of the problem in Writer
Comment 2 Telesto 2021-08-13 15:33:29 UTC
*** Bug 143530 has been marked as a duplicate of this bug. ***
Comment 3 Timur 2021-08-14 05:38:50 UTC
*** Bug 143330 has been marked as a duplicate of this bug. ***
Comment 4 Commit Notification 2021-09-15 07:43:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e1a5bcb20e15400320f926165b6d798fa36c564e

tdf#143831 fix black background appearing on spellchecking wavy lines

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-09-15 07:45:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/17e22f416fde350d89b935922911f0172cdeaa8c

Related: tdf#143831 add guards to ImplDrawWaveLineBezier

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-09-15 07:45:18 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2987a0f4d38463a167e23c243668974d2cb863fb

Related: tdf#143831 the svp aliased case ends up overly washed out

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2021-10-06 08:21:18 UTC
Verified in: 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded