| Summary: | LO crashes during mail merge wizard when an address block is modified | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | P Cunningham <patrick> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 79045_79045, avd.sharpa, caolan.mcnamara, m.weghorn, patrick |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.2.0.4 release | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| Whiteboard: | target:7.3.0 target:7.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 102998 | ||
| Attachments: |
odt document 'Invoice'
ods data source |
||
|
Description
P Cunningham
2021-08-26 15:50:27 UTC
Please attach your ODT document and some simple ODS with non real addresses for checking Created attachment 174601 [details]
odt document 'Invoice'
Created attachment 174602 [details]
ods data source
Steps to reproduce: 1. open 'Invoice.odt' 2. Tools>Mail Merge Wizard 3. Insert Address Block> check 'This document shall contain an address block' 4. More > Edit 5. rearrange to give: <Company Name> <Address Line 1> <Address Line 2> <Post Town> <Postcode> 6. Click 'OK' - Crash! The result is the same if the fields have been previously matched or not. Confirm in Version: 7.2.0.1.0+ (x64) / LibreOffice Community Build ID: c3dd27d24dec0c581ed731acf8ff3504a4068b03 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded https://crashreport.libreoffice.org/stats/crash_details/9ee66cc9-3d8c-435b-833c-f9c8ceb107ed but not in 7.1.3 => regression I bisected it and got https://git.libreoffice.org/core/commit/1320afe376bc52bc64995ba976391ec21db6ccde https://gerrit.libreoffice.org/c/core/+/114846 Added to CC: Caolán McNamara *** Bug 144154 has been marked as a duplicate of this bug. *** Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/03e108f27b91dddc8fabc6f52f18afd6aac8666a tdf#144105 crash after closing edit address block dialog It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. that should do it, backport to 7-2 and 7-2-1 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/e7d7b013bc3014b8df78118ca0790bda121af501 tdf#144105 crash after closing edit address block dialog It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Version: 7.2.2.0.0+ (x64) / LibreOffice Community Build ID: 72fa08057ad46d998f315f17f71c9b8aa65d2e14 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded Unfortunately this doesn't seem to have fixed the issue. Using the same test .odt and .ods documents I uploaded I still get the same result following the same steps. Thank you for your help! Sorry, I just realised the build I downloaded was dated before your last post here. I'll try again tomorrow. Thank you again!!! (In reply to P Cunningham from comment #12) > Sorry, I just realised the build I downloaded was dated before your last > post here. I'll try again tomorrow. > > Thank you again!!! Better try after two days after merged fix Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2-1": https://git.libreoffice.org/core/commit/c7c209ddb55da8b8e49e1a37bb49816987d8e109 tdf#144105 crash after closing edit address block dialog It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. This is now working much better in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: bc7baa18435000f47f90e47d3300710bcb4cf56b CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded - thank you! But 'Suppress lines with just empty fields' doesn't seem to be working. Just to be clear, if I have some records with all the lines filled and some records with one line empty (<Address line 2>, which maps to <Client Address 2>), the empty line is not suppressed. (In reply to P Cunningham from comment #16) > Just to be clear, if I have some records with all the lines filled and some > records with one line empty (<Address line 2>, which maps to <Client Address > 2>), the empty line is not suppressed. I think it's another problem, please file a new bug report. Thank you |