| Summary: | Result with "Precision as shown" with custom string+General number format becomes 0 | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Calc | Assignee: | Eike Rathke <erack> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | erack, nemeth, varga.balazs3, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 7.2.0.4 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=136794 https://bugs.documentfoundation.org/show_bug.cgi?id=137063 https://bugs.documentfoundation.org/show_bug.cgi?id=143950 |
||
| Whiteboard: | target:7.3.0 target:7.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Example file from Calc
Screenshot of the problem in Calc |
||
|
Description
NISZ LibreOffice Team
2021-08-31 10:36:50 UTC
Created attachment 174661 [details]
Screenshot of the problem in Calc
Brilliant.. the document has precision as shown enabled and ScDocument::RoundValueAsShown() for this format calls rtl_math_round() with a precision/decimals of -3000 which of course yields 0 now (and previously was simply ignored). Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/71b003a12f8afdff42a25786ad0a12ddd6609d59 Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown() It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/c/core/+/121459 for 7-2 https://gerrit.libreoffice.org/c/core/+/121460 for 7-2-1 Verified in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c085fc7cd335e3ea50a6bbaedf2f6e8cffadf559 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Eike, thanks for fixing this issue!! Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/3879accdfbee52b3bbecbe20fd1cf4d391189b70 Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown() It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d98aae68810a77df399decbe09ba70f99fdb7344 tdf#144209: sc_subsequent_filters_test2: Add unittest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-2-1": https://git.libreoffice.org/core/commit/eedfa91e777423cb3cd025c8eafd7e031c98f6b9 Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown() It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |