Bug 144618

Summary:	Standard Filter Dialog doesn't show up with GTK3
Product:	LibreOffice	Reporter:	Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt>
Component:	UI	Assignee:	Julien Nabet <serval2412>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caolan.mcnamara, samuel.mehrbrodt, serval2412, xiscofauli
Priority:	medium	Keywords:	haveBacktrace
Version:	7.3.0.0 alpha0+
Hardware:	All
OS:	Linux (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=143103
Whiteboard:	target:7.3.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	142076
Attachments:	gdb bt bt with debug symbols

Description Samuel Mehrbrodt (allotropia) 2021-09-20 10:15:45 UTC

With GTK3 VCL Backend:

1. Open attachment 172194 [details].
2. Click the autofilter dropdown
3. Choose "Standard filter"

Expected: Standard filter dialog shows up

Actual: Dialog not shown. Some GTK errors shown on console:
Gtk-CRITICAL **: 12:12:16.665: gtk_cell_layout_add_attribute: assertion 'column >= 0' failed

Dialog works with "gen" backend.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 73ad4bc218b5a2c3f8b25e0cf4e3858cddfb4d01
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

GTK Version: 3.24.25

Comment 1 Julien Nabet 2021-09-20 19:49:32 UTC

Created attachment 175150 [details]
gdb bt

On pc Debian x86-64 with master sources updated today + gtk3 rendering, I could reproduce this.

Comment 2 Julien Nabet 2021-09-20 19:51:57 UTC

Created attachment 175151 [details]
bt with debug symbols

I used export G_DEBUG=fatal_warnings and retrieved the bt for the first Gtk-CRITICAL

Comment 3 Julien Nabet 2021-09-21 20:33:27 UTC

I gave a try with https://gerrit.libreoffice.org/c/core/+/122409

Comment 4 Xisco Faulí 2021-09-21 21:24:00 UTC

Regression from

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d9dd003f63a781e63bfbe380ea737e080c21881f

author	Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>	2021-09-09 09:33:49 +0200
committer	Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>	2021-09-16 16:21:19 +0200
commit d9dd003f63a781e63bfbe380ea737e080c21881f (patch)
tree 35defd81fdfb99b6254f8d5011fe3dd42297d248
parent 40f38fd16dad4374543d4a7a109b3264837ce8d1 (diff)
tdf#143103 Support Color Filter in "Standard Filter" dialog

Bisected with bibisect-linux64-7.3

Comment 5 Commit Notification 2021-09-22 08:09:53 UTC

Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/41ccb5c63c94e54b07707eca62bed761c87b0d10

tdf#144618: fix Standard Filter Dialog with gtk3

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 Commit Notification 2021-09-23 07:56:40 UTC

Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f8ec7fb5751e3e120d0e09466b006085cea13fe

Related tdf#144618: add check in bin/ui-rules-enforcer.py

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.