| Summary: | Crash when trying to modify a style (gtk3 only) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Jean-Baptiste Faure <jbfaure> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | caolan.mcnamara, serval2412, suokunlong |
| Priority: | high | Keywords: | haveBacktrace, regression |
| Version: | 7.3.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.3.0 target:7.2.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | bt with debug symbols | ||
|
Description
Jean-Baptiste Faure
2021-09-25 23:00:18 UTC
Created attachment 175277 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today and with gtk3 rendering only (not with kf5 or gen rendering), I could reproduce this.
Here's an even more straightforward to reproduce this.
- launch Writer
- Click Style menu
- Select Edit Style...
=> Crash
I don't reproduce this with LO Debian package 7.2.1.2 Here's a straightforward patch but is it the right way to fix this?
diff --git a/svx/source/dialog/frmsel.cxx b/svx/source/dialog/frmsel.cxx
index 435cd489d482..361503690f9b 100644
--- a/svx/source/dialog/frmsel.cxx
+++ b/svx/source/dialog/frmsel.cxx
@@ -824,6 +824,7 @@ bool FrameSelectorImpl::SelectedBordersEqual() const
FrameSelector::FrameSelector()
{
+ mxImpl.reset( new FrameSelectorImpl( *this ) );
}
void FrameSelector::SetDrawingArea(weld::DrawingArea* pDrawingArea)
I'd just move the line to before the set_size_request which triggers the crashign callback (In reply to Caolán McNamara from comment #5) > https://gerrit.libreoffice.org/c/core/+/122631 This patch fixes the crash for me. Best regards. JBF Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c92a29fd6ef341a1657f90759d20e4f052b45843 tdf#144729 create FrameSelectorImpl before setting size request It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. done in trunk, backport to 7-2 in gerrit I confirm I don't reproduce the crash after your patch Caolán, thank you! :-) Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/2b96bf1fd8f4287a06b79dbec14114ca6c035731 tdf#144729 create FrameSelectorImpl before setting size request It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2-2": https://git.libreoffice.org/core/commit/44dd4ea32bf4b21385f6eb8e96aa4115291adebf tdf#144729 create FrameSelectorImpl before setting size request It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Julien Nabet from comment #9) > I confirm I don't reproduce the crash after your patch Caolán, thank you! :-) Idem for me on both master and LO 7.2.3.0.0+. Thank you very much Caolán! Best regards. JBF *** Bug 144791 has been marked as a duplicate of this bug. *** |