Bug 144735

Summary:	UI: Context menu to access edit mode for table formula
Product:	LibreOffice	Reporter:	Dave McKellar <dmckellar>
Component:	Writer	Assignee:	Heiko Tietze <heiko.tietze>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	medium
Version:	7.2.1.1 rc
Hardware:	All
OS:	All
Whiteboard:	target:7.3.0
Crash report or crash signature:		Regression By:
Attachments:	A simple ODT file with a field forumla in a table Screen shot of me right-clicking on the field formula in a table

Description Dave McKellar 2021-09-26 15:41:00 UTC

Description:
I inserted a field formula (eg 100 + 200) into a table.
But then there is no choice in the right-click menu to edit it.
There was a choice in the right-click menu to edit a field date in a table.


Steps to Reproduce:
1.  Insert a field formula (eg 100 + 200) into a table
2.  Right-click on the field formula and the menu has no choice to edit it


 

Actual Results:
The right-click menu does not have a choice to edit the field formula.
And the field formula does not have a gray background like other fields (eg date).

Expected Results:
With other fields (eg date) in a table there is a choice in the right-click menu to it.
Field formulas should have that option too.


Reproducible: Always


User Profile Reset: No



Additional Info:
- There is a an edit option in the right-click menu for field formulas (eg 100 + 200) when not in a table
- Other fields like date work in table

Comment 1 Dave McKellar 2021-09-26 15:41:57 UTC

Created attachment 175280 [details]
A simple ODT file with a field forumla in a table

Comment 2 Dave McKellar 2021-09-26 15:45:24 UTC

Created attachment 175281 [details]
Screen shot of me right-clicking on the field formula in a table

I cannot see a choice to edit it.

Comment 3 Mike Kaganski 2021-09-26 16:09:16 UTC

F2 does that; it is not a field, but a table cell formula, hence the difference.

But a context menu would be useful, this would be a good enhancement.

Comment 4 Telesto 2021-09-27 17:43:40 UTC

(In reply to Mike Kaganski from comment #3)
> F2 does that; it is not a field, but a table cell formula, hence the
> difference.
> 
> But a context menu would be useful, this would be a good enhancement.

Lets throw this at UX as a formality. And in the hopes of an EasyHack status..

Comment 5 Heiko Tietze 2021-09-28 07:12:59 UTC

Absolutely, we should list the function in the context menu (the main menu has it under Table).

It's .uno:InsertFormula required in table.xml. But "Text Formula" is not a speaking name to me and I suggest "Edit Formula" here. The function does not distinguish between Insert and Edit, it just shows the formula bar initialized with or without content.

Comment 6 Heiko Tietze 2021-09-28 07:35:21 UTC

https://gerrit.libreoffice.org/c/core/+/122752

Comment 7 Commit Notification 2021-09-28 09:08:20 UTC

Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ac34bafb6cad056f843ff3ff0dee293bf1e18c56

Resolves tdf#144735 - Access to formula edit bar via context menu

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.