Bug 144891

Summary:	Image frame size squeezed at undo
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	Writer	Assignee:	Attila Bakos (NISZ) <bakos.attilakaroly>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	bakos.attilakaroly, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.3.0.0 alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=143574 https://bugs.documentfoundation.org/show_bug.cgi?id=144271
Whiteboard:
Crash report or crash signature:		Regression By:
Attachments:	Bugdoc, afer undo, without the problem in Writer 7.3 screencast Screencast The first bad commit

Description Telesto 2021-10-03 10:59:21 UTC

Description:
Image frame size squeezed at undo

Steps to Reproduce:
1. Open the attachment 164237 [details]
2. Pick up image frame and drag it to the top of the page
3. Undo

Actual Results:
Frame size broken

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: b60b6bfaafa1315e07108dba50f016975b619c59
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-US
Calc: CL

Comment 1 Telesto 2021-10-03 11:04:09 UTC

Not in
Version: 7.2.1.0.0+ (x64) / LibreOffice Community
Build ID: 8fdbb8aed1b48734a717d5f98ada566de7204605
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Comment 2 Xisco Faulí 2021-10-04 09:53:43 UTC

Reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: af291666b3316aba2b35d3b8358f4cd42c553587
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Comment 3 Xisco Faulí 2021-10-04 10:05:41 UTC

Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ba5156abace2e41ec4d21397c0875f7e1efd2beb

author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	2021-09-01 16:38:07 +0200
committer	László Németh <nemeth@numbertext.org>	2021-09-16 12:56:10 +0200
commit ba5156abace2e41ec4d21397c0875f7e1efd2beb (patch)
tree d09d5116f32263c385d34156fd0841f51105c099
parent e58e828d4877f9068e4a69c52ac9c7fe6e65d032 (diff)
tdf#143574 tdf#144271 sw: textboxes in group shapes - part 2

Bisected with: bibisect-linux64-7.3

Adding Cc: to Attila Bakos

Comment 4 Attila Bakos (NISZ) 2021-10-05 08:38:46 UTC

No reproduction with above mentioned steps, with:

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: b1488cd6f008049a9aaff7350deeb73cbbd535b6
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

See my attachment, or please attach a photo of the problem.

Instead of the above mentioned steps, i could reproduce a frame size problem, with the same version with these steps:

1)Open attachment 164237 [details]
2)Resize the frame
3)Undo

-> The frame width not changed back.

Is this the same problem???

Comment 5 Attila Bakos (NISZ) 2021-10-05 08:41:06 UTC

Created attachment 175527 [details]
Bugdoc, afer undo, without the problem in Writer 7.3

Comment 6 Xisco Faulí 2021-10-05 08:50:20 UTC

Created attachment 175528 [details]
screencast

Comment 7 Telesto 2021-10-05 09:06:09 UTC

Created attachment 175529 [details]
Screencast

Same as Xisco, except I don't expand the frame

Comment 8 Attila Bakos (NISZ) 2021-10-05 10:03:52 UTC

Oh i see. You change the size, so that is the same, because i misunderstand the steps and i moved only the frame. Thanks. Fix coming soon.

Comment 9 Attila Bakos (NISZ) 2021-10-05 11:44:30 UTC

Created attachment 175539 [details]
The first bad commit

just i was curious, and bisected this issue 2 times again, and i get for first bad build (as this in my attachment):

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 1feb59c3dd9e5f714ce894f8de31bbb6869c9f3b
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Comment 10 Attila Bakos (NISZ) 2022-03-07 12:21:03 UTC

Setting as dupe of 146449 because the patch what fixes that fixes this one too.
Patch: https://gerrit.libreoffice.org/c/core/+/130875

*** This bug has been marked as a duplicate of bug 146449 ***