Bug 145216

Summary:	remote open/save dialog: icon view shows nothing
Product:	LibreOffice	Reporter:	Justin L <jluth>
Component:	Writer	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caolan.mcnamara, jluth
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.0.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=128940 https://bugs.documentfoundation.org/show_bug.cgi?id=145169
Whiteboard:	target:7.2.3 target:7.3.0
Crash report or crash signature:		Regression By:

Description Justin L 2021-10-19 06:57:47 UTC

Starting with LO 7.0, the remote open/save dialog can only show file details, and not file icons. This broke with commit b004a1bd7bf3885613d52aba70dea79766eae639
Author: Caolán McNamara on Sat Nov 23 19:14:45 2019 +0000
    Resolves: tdf#128940 use a normal MenuButton

This was caused by the removal of 
                          <object class="GtkIconView" id="iconview">
                            <property name="model">liststore2</property>
-                            <property name="pixbuf_column">0</property>
-                            <property name="text_column">1</property>

Comment 1 Caolán McNamara 2021-10-19 07:58:57 UTC

that certainly wasn't intentional

Comment 2 Commit Notification 2021-10-19 09:19:28 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/2a5b91903a4a5572bfd7f6c53799d717838bf8a6

tdf#145216 remote open/save dialog: icon view shows nothing

It will be available in 7.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Commit Notification 2021-10-19 09:41:18 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3b3154f6c2517155b1253ce9ff773c470bb31093

tdf#145216 remote open/save dialog: icon view shows nothing

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Caolán McNamara 2021-10-19 09:41:38 UTC

done in trunk, backport to 7-2 in gerrit