Bug 145486

Summary: LO crashes with finalized ooSetupLastVersion
Product: LibreOffice Reporter: Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt>
Component: LibreOfficeAssignee: Homeboy_445 <akshitsan13>
Status: RESOLVED FIXED    
Severity: normal CC: akshitsan13, himajin100000, quikee, samuel.mehrbrodt, serval2412, xiscofauli
Priority: medium Keywords: bisected, haveBacktrace, regression
Version: 7.3.0.0 alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:7.3.0 target:7.4.0
Crash report or crash signature: Regression By:
Attachments: config snippet
bt with debug symbols

Description Samuel Mehrbrodt (allotropia) 2021-11-01 08:57:14 UTC 
Created attachment 176051 [details]
config snippet

1. Install the attached config snippet via Extension manager
2. Start Writer

Expected: Writer starts
Actual: LO crashes

This is broken since https://git.libreoffice.org/core/commit/07e269f2596756bf841bbc380929bcffc3ca6bc6

include/unotools/VersionConfig.hxx tries to update officecfg::Setup::Product::ooSetupLastVersion but it fails since it's a finalized property.
Comment 1 Julien Nabet 2021-11-01 11:47:15 UTC 
Created attachment 176058 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I used gdb and catch throw to find it.
Comment 2 Commit Notification 2021-11-02 06:48:33 UTC 
homeboy445 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab32d1c01814d576b0b82c99e1849a8a71b12188

tdf#145486: Prevented crash by not updating readOnly value

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2022-03-01 12:21:56 UTC 
homeboy445 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1c2dc4bc28a594c15464fdb0f5adaa30baf47af2

tdf#145486: Catch the error instead of re-checking readOnly state

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.