| Summary: | Find and replace: incorrect replacement after reopening the dialog | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
| Component: | Impress | Assignee: | Justin L <jluth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jluth, quikee, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=122788 | ||
| Whiteboard: | target:7.4.0 target:7.3.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Xisco Faulí
2021-11-24 12:15:18 UTC
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2ebc26aeefefe33ee6180862509e4971ff2dfc6f author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2020-08-22 21:45:44 +0200 committer Tomaž Vajngerl <quikee@gmail.com> 2020-08-29 13:14:04 +0200 commit 2ebc26aeefefe33ee6180862509e4971ff2dfc6f (patch) tree 9540fbb5cf497e907b738c59a83a338ce643e975 parent 88e52e539eaf7981441ec3e042f321c2615919ca (diff) sd: Make search bound to a view - to allow independent searching Bisected with: bibisect-linux64-7.1 Adding Cc: to Tomaž Vajngerl This seems like a very specific instance of a general case that started even earlier. 1.) Press Ctrl-H to open a find/replace dialog 2.) search: "second", and replace: "junk". Press either find or replace button -this "finds" the first instance of second - good 3.) change to search: "first". Press replace button -this replaces "second" with "junk" and finds "first" - bad Bibisecting this was just nasty. I either got on a streak of "good", or "bad". But later on when retesting, I had lots of "good" results in 42max, but then when it wasn't consistent I retested "oldest" and it was "bad". Also bad in oldest of 41max. Incomprehensible. Note the # FIXME: tdf#145868 in sd/qa/uitest/findReplace/findReplace.py Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/583185235389b55d6cfffac3067c0e1ccb2852b1 related tdf#145868 sd: Clone SvxSearchItem to avoid use after free It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/32c946c064cc2889bda2f46c1862e5100f0a257a tdf#145868 sd replace: if search changes, restart find/replace It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/dc3f27c910f455fce7a3afe3115ba51effd5e63f related tdf#145868 sd: Clone SvxSearchItem to avoid use after free It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/0e1d4fec1b701c334c1e320f4d58c939aaa82910 tdf#145868 sd replace: if search changes, restart find/replace It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |