Bug 146161

Summary:	Consider renaming button "open" in templates dialog
Product:	LibreOffice	Reporter:	lol <lobugs>
Component:	UI	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	enhancement	CC:	heiko.tietze, mentoring
Priority:	lowest	Keywords:	difficultyBeginner, easyHack, skillDesign, topicUI
Version:	7.2.3.2 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=104074
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	101435

Description lol 2021-12-10 11:16:20 UTC

If you click in the writer templates dialog (File - New - Templates) on the button open after selecting a template, a new document based on the selected template will be creating. All changes to this document are saved to a new document. They are not saved to the template. So you created a new document. Therefore the button "open" should renamed to "create". You cannot open a template in this dialog to edit it. This can be done via File - Templates - Edit Template. 

I think the word open refers to something which already exist. The word create refers to something which not yet exist.

Comment 1 Roman Kuznetsov 2022-08-06 15:26:06 UTC

I don't think it's matter for users (who read the guide of course)

UX-team, we need your opinion here

Comment 2 Heiko Tietze 2022-08-08 07:45:52 UTC

"Create" sounds to me as setting-up a new template. We could go with "New From Template" but besides being quite long it's not much of an improvement. Is Open really that misleading? 

We discussed in this context File > New > Template... and File > Templates > Manage Templates in bug 104074 and decided to rename the first and to consider removing the second (see also bug 123216). Would prefer meanwhile to drop the first. Or keep both.

Comment 3 Eyal Rozenberg 2022-08-09 09:29:58 UTC

(In reply to Roman Kuznetsov from comment #1)
> I don't think it's matter for users (who read the guide of course)

Users don't read the guide... Even assuming users have read the help is usually too strong of an assumption.

In reply to Heiko Tietze from comment #2)
> "Create" sounds to me as setting-up a new template.

Granted, "Create" is a bit ambiguous, although the fact that you're selecting an existing template suggests you're no creating a new one. But "Open" absolutely sounds like you're opening the template you've chosen, for editing. So, "Create" is much better than "Open". So,

> Is Open really that misleading? 

Yes.

> We could go with "New From Template"

This hints that the currently selected template is not the one to be used.

My suggestion: "Use" or "Apply" or "Use Template".

Benefits:

* Terse.
* Not ambiguous, i.e. you're using/applying something existing, and that something can only be the template you've chosen.

Detriments:

* The short names are slightly vague.

Comment 4 Heiko Tietze 2022-08-11 13:27:08 UTC

I'd prefer "New From Template" for both the dialog's button and the menu item.

Code pointers:
sfx2/uiconfig/ui/templatedlg.ui
officecfg/registry/data/org/openoffice/Office/Common.xcu -> .uno:NewDoc

(I wonder how this works together with officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu where the command is defined again but for Manage Templates. Guess the m14 command is used in the New menu.)

Comment 5 Sujatro Bhadra 2024-03-16 16:54:47 UTC

It seems that the "Open" button label is not changed even when it is changed directly from the 
sfx2/uiconfig/ui/templatedlg.ui

I cannot seem to understand how/if officecfg/registry/data/org/openoffice/Office/Common.xcu affects this (along with officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu). I can see the newDoc function but those does not seem to affect the functionalities of the gtk-button.

Comment 6 Heiko Tietze 2024-03-18 10:08:28 UTC

Correct code pointer:

In sfx2/source/doc/templatedlg.cxx line #235
mxOKButton->set_label(SfxResId(STR_OPEN)); (STR_OPEN is used at many places)