| Summary: | section setting endnote "collect at end of section" does not update layout | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Michael Stahl (allotropia) <michael.stahl> |
| Component: | Writer | Assignee: | Attila Szűcs <attila.szucs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | attila.szucs, eagleview7 |
| Priority: | medium | Keywords: | bisected, regression |
| Version: | 7.3.0.1 rc | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=146605 | ||
| Whiteboard: | target:7.4.0 target:7.3.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Michael Stahl (allotropia)
2022-01-11 20:46:43 UTC
If this regression can't be fixed properly in a timely manner, would it be possible to at least mitigate the problem with the following fix?
In sw/source/uibase/app/docshini.cxx, line 292 needs to be changed from:
m_xDoc->getIDocumentSettingAccess().set( DocumentSettingId::FOOTNOTE_IN_COLUMN_TO_PAGEEND, true);
to:
m_xDoc->getIDocumentSettingAccess().set( DocumentSettingId::FOOTNOTE_IN_COLUMN_TO_PAGEEND, false);
The endnote correctly changes position with this fix, but it may revert prior fixes from bug 139336, which caused this regression.
@Attila Szucs Is there any status update on a fix for this regression? (In reply to David from comment #2) > @Attila Szucs > Is there any status update on a fix for this regression? It is easy to fix.. i will upload a patch to gerrit soon.. Michael Stahl is right, the problem is in the FindFootnoteBossFrame .. i did not know that endnotes use this function too.. so i just need to add +1 condition for my changes. Sorry .. i just had a lot of changes in my workspace... so i did not have much time to code ... :( (In reply to Attila Szűcs from comment #3) > Sorry .. i just had a lot of changes in my workspace... so i did not have > much time to code ... :( Is there any possibility that this could be fixed in time for the 7.3.1 release? Attila Szűcs committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9a457c24ab2731c99f1a5fa1d28f68788e6977f3 tdf#146704 sw: fix regression of endnote layout in sections It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Attila! Works correctly now! Attila Szűcs committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/dbfa2662a6d9a9b53f95198313374f5529978836 tdf#146704 sw: fix regression of endnote layout in sections It will be available in 7.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Attila Szűcs committed a patch related to this issue. It has been pushed to "libreoffice-7-3-1": https://git.libreoffice.org/core/commit/76ff5c9dc5a4525067da3de485ac9d0924ab6172 tdf#146704 sw: fix regression of endnote layout in sections It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6adabd915d931b845fcf2fef15fbf3fca14ec9b3 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded |