Bug 146803

Summary:	FILEOPEN DOCX Spacing to border incorrect in grouped shape
Product:	LibreOffice	Reporter:	Gabor Kelemen (allotropia) <kelemeng>
Component:	Writer	Assignee:	Attila Bakos (NISZ) <bakos.attilakaroly>
Status:	VERIFIED FIXED
Severity:	normal	CC:	aron.budea, bakos.attilakaroly, libreoffice, nemeth, varga.balazs3
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.4.0.0 alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=143574
Whiteboard:	target:7.4.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	136328
Attachments:	Minimized example file The example file in Word 2013 and current master side by side

Description Gabor Kelemen (allotropia) 2022-01-16 23:04:40 UTC

Created attachment 177589 [details]
Minimized example file

Attached document was minimized from attachment 96245 [details] and has a grouped shape with internal text box borders defined.
These are read/applied incorrectly to the grouped shapes and that makes their text not fit in them.

1, Open attached file, notice the texts are flowing out of the squares
2, Right click the group and choose Ungroup
3, Select a square with text and choose Format - Text box and Shape - Text Attributes
4, Compare Spacing to Borders to Word values

Expected: all 4 borders should be 0,04 cm and all text should fit

Actual: borders are 0,25 cm left/right and 0,13 cm top/bottom.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3b48e20b0101584a5e7ef48ba82238e735f0772b
CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Not yet in 7.3.0

Started in:
https://git.libreoffice.org/core/+/2951cbdf3a6e2b62461665546b47e1d253fcb834

author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	Wed Nov 10 14:10:11 2021 +0100
committer	László Németh <nemeth@numbertext.org>	Mon Jan 03 14:28:15 2022 +0100

tdf#143574 OOXML export/import of textboxes in group shapes

Adding CC to: Attila Bakos

Comment 1 Gabor Kelemen (allotropia) 2022-01-16 23:05:17 UTC

Created attachment 177590 [details]
The example file in Word 2013 and current master side by side

Comment 2 Aron Budea 2022-01-17 00:38:20 UTC

Confirmed using LO Version: 7.4.0.0.alpha0+ (b4a281af53efa0c36ee1770e6cf4d800be77a6d2) / Windows.

Comment 3 Commit Notification 2022-02-03 08:29:11 UTC

Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/65b09ef1c5e24651579eb11900cf2ddbbb7b0971

tdf#146803 tdf#146805 OOXML import: fix bodyPr at grouped shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 NISZ LibreOffice Team 2022-02-14 07:39:24 UTC

Verified in:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 42c5506a9e9ef58efd8193a193464e3b49d481ca
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded