Bug 146965

Summary: sw track changes: regression: broken moving of table row
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: VERIFIED FIXED    
Severity: normal CC: nemeth
Priority: medium Keywords: bibisected, filter:odt, regression
Version: 7.4.0.0 alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:7.4.0 target:7.3.1
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 143002    
Attachments: Example file from Writer with a table
Screenshot from the problem

Description NISZ LibreOffice Team 2022-01-24 12:47:00 UTC
Description:
After the  table row moving with change tracking, it will be a nested table instead of change the table row

Steps to Reproduce:
    1. Open attached file
    2. Click on the left border of the first table row for selection 
    3. Drag the selected row into the last one. 

Actual Results:
The row inserted as a nested table instead of a row before the last row.

Expected Results:
It should just change the row


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 86a9c860410351125708543c1050bfc0977d3b97
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

Bibisected: dbc82c02eb24ec1c97c6ee32069771d8deb394f9
"tdf#143358 (https://bugs.documentfoundation.org/show_bug.cgi?id=143358) sw: track insertion of empty table rows
Comment 1 NISZ LibreOffice Team 2022-01-24 12:48:06 UTC
Created attachment 177751 [details]
Example file from Writer with a table
Comment 2 NISZ LibreOffice Team 2022-01-24 12:48:33 UTC
Created attachment 177752 [details]
Screenshot from the problem
Comment 3 Commit Notification 2022-01-25 08:52:24 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a1c19624eda0c8b847af0dcee70b82502578ceb

tdf#146965 sw track changes: fix tracked table row moving

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 László Németh 2022-01-25 09:11:42 UTC
Description of the fix:

tdf#146965 sw track changes: fix tracked table row moving

During track changes, drag & drop or Cut & Paste
a table row resulted a nested table in the first cell of
the newly inserted empty table row instead of moving
the original table row.

Test: select a table row by clicking on their left border,
and drag & drop or Cut & Paste it in a different
table row.

Note: This fixes crashing at Redo of tracked table row
insertion, too.

Regression from commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9
"tdf#143358 sw: track insertion of empty table rows".
Comment 5 Commit Notification 2022-01-25 15:14:50 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/8aab37daf004ed31c67f21a352fba95ab1229086

tdf#146965 sw track changes: fix tracked table row moving

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 NISZ LibreOffice Team 2022-02-09 08:48:27 UTC
Verified in:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5c138ac6a8334825ef171ac6291b66b277eb4288
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL