| Summary: | Incorrect handling of right-hand argument to "\" Integral Division BASIC operator | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
| Component: | BASIC | Assignee: | Andreas Heinisch <andreas.heinisch> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andreas.heinisch, himajin100000 |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.4.0 target:7.3.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 127592 | ||
Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3ba8b56b32c203326b776b940d20b16eb2340835 tdf#147089 - Round Integral Division (IDIV) literals to Integer values It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Andreas Heinisch committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/1f0c42c3e91378d6e03e854711aa389f4c215a96 tdf#147089 - Round Integral Division (IDIV) literals to Integer values It will be available in 7.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Consider the code: Sub testIntDiv() MsgBox 5 / 4 & Chr(10) & _ 5 \ 4 & Chr(10) & _ 7 / 4 & Chr(10) & _ 7 \ 4 & Chr(10) & _ 7 / 3.5 & Chr(10) & _ 7 \ 3.5 & Chr(10) & _ 6.5 / 3.5 & Chr(10) & _ 6.5 \ 3.5 & Chr(10) End Sub It is intended to give the following result: 1,25 1 1,75 1 2 1 1,85714285714286 1 Instead, it produces 1,25 1 1,75 1 2 2 1,85714285714286 2 See how '7 \ 3.5' and '6.5 \ 3.5' produce 2 instead of expected 1 - according to the proper "first round both operands to nearest integer, then return truncated result of division". Note that even using 3.9 instead of 3.5 gives the same wrong result. This also deviates from VBA.