Bug 148017

Summary: harmonize .ui file widget construction for sidebar
Product: LibreOffice Reporter: andreas_k <kainz.a>
Component: UIAssignee: andreas_k <kainz.a>
Status: RESOLVED FIXED    
Severity: enhancement CC: 79045_79045, caolan.mcnamara, heiko.tietze, kainz.a, szymon.klos, telesto, xiscofauli
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=160208
Whiteboard: target:7.5.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103459    

Description andreas_k 2022-03-15 19:32:31 UTC 
The sidebar .ui files are gtkboxes, gtkgrids, boxes within boxes, ...

As the construction is nearly always different I would suggest to harmonize the structure so that if someone will theme the sidebar the structure is always the same and it's than way easier to do any generic stuff for all sidebar elements.

From my point of view, I would have

gtkbox
 gtkbox (label left aligned) space gtkbox (right aligned)

that's it.

So if someone want to define a fix width for the right aligned gtkwidgets (dropdown, input field, ...) everything will be aligned.
Comment 1 andreas_k 2022-03-15 19:34:25 UTC 
And yes this harmonization will help also CollaboraOnline sidebar .css theming.
Comment 2 Roman Kuznetsov 2022-09-28 15:08:19 UTC 
Heiko, what do you think? 
Personally I always support simplification ideas =)

Btw, gtkGrid may be more universal?
Comment 3 Heiko Tietze 2022-09-28 15:35:18 UTC 
In most cases a GtkGrid should result in a cleaner layout. The sidebar consists however of a number of different UIs and it depends.
Comment 4 Szymon Kłos 2022-09-29 07:32:49 UTC 
I agree with @Heiko grid gives us warranty all the rows will be equally aligned. If we have box for every row - all the cells will be positioned individually.
Also sometimes we don't use "merging cells" feature of a grid so there is a box inside grid and things become more complex :)
Comment 5 andreas_k 2022-09-29 08:28:31 UTC 
Ok than let's go with a grid for all sidebar UI files.

It will take some time, but I will propose some Merge Requests.
Comment 6 Commit Notification 2022-10-17 17:16:17 UTC 
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e960180092a30738655e7e091b51f690914461ce

tdf#148017 harmonize sidebar .ui files

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Roman Kuznetsov 2022-10-17 18:22:23 UTC 
Fixed?
Comment 8 andreas_k 2022-10-17 19:13:23 UTC 
Charts ui files will come soon.
Comment 9 Commit Notification 2022-11-08 08:57:39 UTC 
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0f0fd9c6e35a86f03606361211067c7887c3e0fc

tdf#148017 harmonize sidebar .ui files for chart2

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.