| Summary: | Automatic font color is not considering brightness of background in edit mode | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Pedro <vermelhusco1904> |
| Component: | Impress | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | dgp-mail, dhinaghena, heiko.tietze, hossein, rizmut, vermelhusco1904 |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=148247 | ||
| Whiteboard: | target:7.5.0 target:7.4.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 143344 | ||
| Attachments: |
Impress active font color is black
Proposed fix: change to white color |
||
Created attachment 179043 [details]
Proposed fix: change to white color
Proposed fix.
The font color is Automatic and becomes white on dark background. But in edit mode it does not take the background into account. No idea here. ImpEditEngine::GetAutoColor() works well but I cannot find the code when the textframe becomes a textedit, or whatever happens with the edit mode. If Hossein doesn't know how to fix it, the quick work-around is to define a color in Font color instead of leaving it in Automatic. Heiko already fixed this. Bravo. I didn't fix this bug. The font color is light by default, but turns out to be dark in editing mode. Happens in all texts on Title as well as Content frame Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2816f498505bab01bc0f17ef0962ece663c607c9 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: id-ID (id_ID.UTF-8); UI: en-US Calc: threaded This happens in any text boxes in Impress or Writer. Also, similar issue with: - background color in slide show mode (white instead of black) -s see bug #148247 - text boundaries in Writer -- see Bug #148092 Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/000a05339b4d7d25aea063a16b7a01ca9080978f Resolves: tdf#148140 get text auto color right in impress edit mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. that seems to address comment #1 at least, backport to 7-4 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/76f8dbf386525ab33844a7fe71b978615247734f Resolves: tdf#148140 get text auto color right in impress edit mode It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. thanks Caolan, it solves the issue here on my macos 10.15 (In reply to dhina from comment #12) > thanks Caolan, it solves the issue here on my macos 10.15 => VERIFIED FIXED |
Created attachment 179042 [details] Impress active font color is black In Impress with LibreOffice Dark Color Scheme, the active font color is black by default. This should be changed to white to increase contrast.