Bug 148211

Summary:	WRITER: Image cropping properties does not work when source image is a linked (not embedded) PDF
Product:	LibreOffice	Reporter:	João Paulo <joaopauloag-freedesktop>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	dgp-mail, joaopauloag-freedesktop
Priority:	medium
Version:	7.2.6.2 release
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Attachments:	PDF sample Screen recording of the steps taken

Description João Paulo 2022-03-26 21:59:40 UTC

Description:
When inserting images (by linking or embedding), we can choose from a variety of formats, including PDF. By going to the inserted image properties, we can crop the image shown without cropping the image file by itself.

However, if the inserted image is a PDF file that was linked and not embedded into the document, the cropping properties just mess the images show and it is not possible to crop properly the image.

Steps to Reproduce:
1. Create a new text document and insert by linking/embedding an image with the PDF format attached on this bug report;
2. Open the shortcut menu on the PDF image, go to Properties, Crop, and change the crop top and bottom values so the image shows only the "PDF" text and not the paper sheet (don't need to be perfect, just to see what will happen next);
3. Save the text document;
4. Reopen the text document;
5. Go to the image properties to change the crop settings there, for example remove the top and bottom crop (reset to zero).

Actual Results:
If the step 1 was chosen to link the PDF image, the end result is a distorted image.

Expected Results:
The PDF image should not be distorted, no matter what inserting method was chosen on the step 1 (linking or embedding).

Reproducible: Always

User Profile Reset: Yes

Additional Info:
I found that when LibreOffice saves a text document with a PDF image embedded, the file inside is changed to PNG instead to being kept as a PDF or changed to a vector format as SVG. So maybe this bug happens because of the image filter making a conversion error.

Also, as PDFs can be converted to SVGs in a visually identical image, even if the metadata or embedded text is lost, maybe this bug can be fixed by changing the way LibreOffice interacts with inserted (linked or embedded) PDFs.

Comment 1 João Paulo 2022-03-26 22:01:03 UTC

Created attachment 179126 [details]
PDF sample

This is the file used on the steps in the bug report.

Comment 2 João Paulo 2022-03-26 22:33:07 UTC

Created attachment 179127 [details]
Screen recording of the steps taken

Comment 3 João Paulo 2022-03-26 23:13:32 UTC

And I just discovered that even when the PDF image is inserted as a link (instead of embedded), Writer saves a PNG version of the PDF inside the .ODT file.

Comment 4 Dieter 2022-04-10 09:56:03 UTC

I can't confirm with

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 040b3198fde3385e19e7380fdcabae84a0abac9d
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. Change to RESOLVED WORKSFORME, if the problem went away.

Comment 5 João Paulo 2022-08-03 22:50:43 UTC

(In reply to Dieter from comment #4)
> I can't confirm with
> 
> Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community

It still hapens with:

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: pt-BR (pt_BR); UI: pt-BR
Calc: threaded Jumbo

I can't use version 7.4.0.2 because the download speed is very slow, almost 6 hours to finish (less than 10KB/s, and it is not my connection speed, it is only this location that is slow: "https://dev-builds.libreoffice.org/pre-releases/win/x86_64/LibreOffice_7.4.0.2_Win_x64.msi").

Comment 6 QA Administrators 2022-08-04 03:35:30 UTC Comment hidden (obsolete)

[Automated Action] NeedInfo-To-Unconfirmed

Comment 7 João Paulo 2022-08-27 05:33:59 UTC

(In reply to Dieter from comment #4)
> I can't confirm with
> 
> Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 040b3198fde3385e19e7380fdcabae84a0abac9d
> CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL:
> win
> Locale: de-DE (de_DE); UI: en-GB
> Calc: CL
> 
> Could you please try to reproduce it with the latest version of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set
> the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if
> the bug is still present in the latest version. Change to RESOLVED
> WORKSFORME, if the problem went away.

It seems that 7.4.0.2 fixed this bug.  I'm closing it as fixed.

Comment 8 Dieter 2022-08-27 05:38:43 UTC

(In reply to João Paulo from comment #7)
> It seems that 7.4.0.2 fixed this bug.  I'm closing it as fixed.

Thank you for retesting.  Should be closed as WORKSFORME,  if it is not clear what fixed the bug.