Bug 148310

Summary: Firebird: copy complete rows, CLOB field, last character lost
Product: LibreOffice Reporter: bugReportLOm
Component: BaseAssignee: Julien Nabet <serval2412>
Status: VERIFIED FIXED    
Severity: normal CC: bugReportLOm, serval2412
Priority: medium    
Version: 7.2.6.2 release   
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard: target:7.4.0 target:7.3.3
Crash report or crash signature: Regression By:
Attachments: example

Description bugReportLOm 2022-04-01 16:48:52 UTC 
Description:
When copying a complete row by clicking the row header with the left mouse button then holding down the button and draging the 
mouse, the cursor will change to a symbol with a + sign. Letting go the row is copied to the last entry of the table.
For CLOB Field Types, with each copy the last character is lost.


I did not notice this in versions before 7.2.6.2 (x64)


Version: 7.2.6.2 (x64) / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 6; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

Steps to Reproduce:
1.copy a row with CLOB field
2.
3.

Actual Results:
last character lost

Expected Results:
full copy


Reproducible: Always


User Profile Reset: Yes



Additional Info:
See tabelle1 in copy-2022-04-01-18-31-38.odb.
Comment 1 bugReportLOm 2022-04-01 16:50:15 UTC 
Created attachment 179258 [details]
example
Comment 2 Julien Nabet 2022-04-01 17:46:51 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Good catch!
Comment 3 Julien Nabet 2022-04-01 17:47:13 UTC 
I submitted a patch here to review:
https://gerrit.libreoffice.org/c/core/+/132443
Comment 4 Commit Notification 2022-04-01 18:41:00 UTC 
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/da81a880df76bebb6d9fbc770c313381a3c33268

tdf#148310: Firebird: copy complete rows, CLOB field, last character lost

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Julien Nabet 2022-04-01 18:45:04 UTC 
Since Jenkins didn't complain, I pushed the patch to master so people can give it a try.

Patch for 7.3 branch waiting for review here:
https://gerrit.libreoffice.org/c/core/+/132378
Comment 6 Commit Notification 2022-04-01 21:20:44 UTC 
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/3507f6e6513cb53e404f2e33d5500fdeb2b7788d

tdf#148310: Firebird: copy complete rows, CLOB field, last character lost

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 bugReportLOm 2022-05-07 09:53:56 UTC 
Works well now, tested with Version: 7.3.3.2 (x64) Windows 10.0 Build 22000

Problem solved.

Thanks to all involved, especially to Julien Nabet.

Version: 7.3.3.2 (x64) / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 6; OS: Windows 10.0 Build 22000; 
UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL
Comment 8 Julien Nabet 2022-05-07 12:40:50 UTC 
You're welcome bugReportLOm! :-)

Let's put this one to VERIFIED then.