| Summary: | i18n: add dv-MV Dhivehi (Maldives) locale data (was: LibreOffice Calc Vs MS Excel Dhivehi Calendar Issues) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Adam, M. A. <adam7171> |
| Component: | Localization | Assignee: | Eike Rathke <erack> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | adam7171, erack, mikekaganski, serval2412 |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Eg file for [Bug 148428] i18n: add dv-MV Dhivehi (Maldives) locale data
Locale dv-MV settings file for [Bug 148428] i18n: add dv-MV Dhivehi (Maldives) locale data changes changes to original submission |
||
|
Description
Adam, M. A.
2022-04-06 16:41:24 UTC
would it be possible you attach an example file? The OP is missing the dv-MV Dhivehi (Maldives) locale data, of which month names are part, which we currently don't have. Someone would have to contribute. For how to contribute locale data please see https://wiki.documentfoundation.org/LibreOffice_Localization_Guide/How_To_Submit_New_Locale_Data Created attachment 179382 [details] Eg file for [Bug 148428] i18n: add dv-MV Dhivehi (Maldives) locale data Please find the raw XLS file as an example for already reported and logged [Bug 148428] i18n: add dv-MV Dhivehi (Maldives) locale data. Created attachment 179383 [details] Locale dv-MV settings file for [Bug 148428] i18n: add dv-MV Dhivehi (Maldives) locale data Contributing suggested and probable fix for already reported and logged [Bug 148428] i18n: add dv-MV Dhivehi (Maldives) locale data. Kind regards from the Maldives. ADAM adam7171@gmail.com [Just in case anyone wants to ask more information.] Thanks a lot! Apparently we don't have your license statement on file, could you please send us a blanket statement that you contribute all your past and future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev mailing list libreoffice@lists.freedesktop.org so we can link to it from https://wiki.documentfoundation.org/Development/Developers Something like this does nicely: All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Best use Subject: <your full name> license statement Sorry for the inconvenience and thank you for cooperating :-) Thanks for submitting the license statement.
Test compiling the data I got:
Error: ListSeparator not ';' semicolon. Strongly recommended. Currently required.
Warning: QuotationStart may be wrong: U+2019 ’
Warning: QuotationEnd may be wrong: U+2018 ‘
Warning: DoubleQuotationStart may be wrong: U+201D ”
Warning: DoubleQuotationEnd may be wrong: U+201C “
Error: ThousandSeparator not present in FormatCode formatindex="4".
Warning: formatindex="4","44","45" are the only FormatCode elements checked for separator usage, there may be others that have errors.
Generated date acceptance pattern: 'D-M-Y' from 'DD/MM/YYYY' (formatindex="21" and defined DateSeparator '-')
Generated 2nd acceptance pattern: 'D/M/Y' from 'DD/MM/YYYY' (formatindex="21")
Error: BankSymbol is not ISO 4217
Warning: ReservedWord trueWord seems to be untranslated "true".
Warning: ReservedWord falseWord seems to be untranslated "false".
Warning: ReservedWord quarter1Word seems to be untranslated "1st quarter".
Warning: ReservedWord quarter2Word seems to be untranslated "2nd quarter".
Warning: ReservedWord quarter3Word seems to be untranslated "3rd quarter".
Warning: ReservedWord quarter4Word seems to be untranslated "4th quarter".
Warning: ReservedWord aboveWord seems to be untranslated "above".
Warning: ReservedWord belowWord seems to be untranslated "below".
The list separator currently needs to be ';' semicolon.
The quotation characters seem to be swapped left and right but that may be due to Dhivehi being a RTL script and might be ok. However, other RTL script locales do not have them swapped so the result may be unexpected if ASCII quotes are automatically replaced with typographic quotes.
The ThousandSeparator is defined as <٬> U+066C ARABIC THOUSANDS SEPARATOR but is not used anywhere, the number format codes use <،> U+060C ARABIC COMMA instead. So which is correct? The Arabic locales use U+060C ARABIC COMMA.
The DateSeparator is defined as <-> U+002D HYPHEN-MINUS but the format codes use </> U+002F SOLIDUS. Which is correct?
BankSymbol must be the ISO 4217 code and is swapped with CurrencySymbol so that should be
<BankSymbol>MVR</BankSymbol>
<CurrencySymbol>ރ.</CurrencySymbol>
and the replaceTo="[$MVR-101]" be changed accordingly (btw, the LCID is not 101 but 465) to replaceTo="[$ރ.-465]" (note the display is swapped RTL here (at least in the Firefox text edit.. we'll see if that persists), the sequence is "[$" CurrencySymbol "-465]"). To get that in the right order with numbers there's a trick that also Arabic locales use (see for example ar_EG.xml), appending a U+200F RIGHT-TO-LEFT MARK to CurrencySymbol in both the element definition and the replaceTo string so following digits in the currency format display are kept in context. (if you don't know how to do that I can do).
You probably want to translate the elements in ReservedWord as well.
Additionally I found
<MeasurementSystem>US</MeasurementSystem>
that probably instead should be
<MeasurementSystem>metric</MeasurementSystem>
Also the LC_INDEX section may need some love. That defines the order in which the Writer table of content (TOC) entries are listed. The current
<LC_INDEX>
<IndexKey phonetic="false" default="true" unoid="alphanumeric">A-Z</IndexKey>
<UnicodeScript>0</UnicodeScript>
<UnicodeScript>1</UnicodeScript>
<FollowPageWord> f.</FollowPageWord>
<FollowPageWord> ff.</FollowPageWord>
</LC_INDEX>
does not match Dhivehi script. See the explanation in
https://git.libreoffice.org/core/+/HEAD/i18npool/source/localedata/data/locale.dtd#540
However, if you keep that as is it doesn't harm but all index entries will appear only in Unicode order.
You may want to translate the two FollowPageWord abbreviations, first for single "following page", second for multiple "following pages".
> Writer table of content (TOC) entries
Bah, that's of course wrong and it's the Index section..
Created attachment 180583 [details] changes As there was no follow-up on this I added data with changes I think make sense. https://gerrit.libreoffice.org/c/core/+/135438 Attached is the diff to the original submission. The warnings about reserved words and quote characters as mentioned in comment 6 remain. At least the reserved words should be translated. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2ba57cd896484411fb2c8527802d551f02d419aa Resolves: tdf#148428 Add Dhivehi (Maldives) {dv-MV} locale data It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 180584 [details]
changes to original submission
Replacing older changes.
|