| Summary: | FILEOPEN PPTX: extra paragraph after some 2-line text with link | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Gerald Pfeifer <gerald> |
| Component: | Impress | Assignee: | Sarper Akdemir (allotropia) <sarper.akdemir.extern> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aron.budea, buzea.bogdan, sarper.akdemir.extern, timur |
| Priority: | medium | Keywords: | filter:pptx |
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=154248 | ||
| Whiteboard: | target:7.6.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107899 | ||
| Attachments: |
Sample slide (PPTX)
Visual comparison Office 365 (left) vs LibreOffice 7.4 (right) Sample slide (PPTX) with font changed to Calibri Visual comparison Office 365 LibreOffice 7.4 with font changed to Calibri Sample slide with font and link changes (PPTX) Visual comparison Office 2016 and LibreOffice 7.4+ for sample with font changeS |
||
|
Description
Gerald Pfeifer
2022-05-06 14:55:18 UTC
Created attachment 179978 [details]
Visual comparison Office 365 (left) vs LibreOffice 7.4 (right)
Confirm the bug with Version: 7.3.3.2 / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded I set to Minor because this seems to be dependent on Poppins font and link. If we add some text after the link in MSO, new line is created after the link, before new text, in LO. Created attachment 180286 [details] Sample slide (PPTX) with font changed to Calibri (In reply to Timur from comment #3) > I set to Minor because this seems to be dependent on Poppins font and link. Hmm, actually not. I changed the font from Poppins to Calibri and the issue still appears. See the attached alternate sample document. Timur, do you mind reconsidering and moving this from minor to normal? Created attachment 180287 [details]
Visual comparison Office 365 LibreOffice 7.4 with font changed to Calibri
Created attachment 180434 [details]
Sample slide with font and link changes (PPTX)
Here is updated sample , to better track font and link changes.
Created attachment 180435 [details]
Visual comparison Office 2016 and LibreOffice 7.4+ for sample with font changeS
Sarper Akdemir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9da4a2518eea880a2c80515d1346effa7c8c8c11 related tdf#148966: rework sdr compatibility flags It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Sarper Akdemir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0bb169dcfa14e6db44bc0eaeabe12d0d3b62ffd8 tdf#148966: pptx: workaround for multiline fields followed by linebreaks It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The initial reported problem is fixed now. But the additional problems later demonstrated by Timur are not. I have attempted to fix the latter case too. The existing multiline field wrapping is a two part hack. One part in ImpEditEngine::CreateLines the other in ImpEditEngine::Paint. Expanding the hack to fix those cases are not really feasible. Instead a proper refactor of the layouting/handling of fields both in EditMode and Paint are required to properly display and wrap multiline fields. (In reply to Sarper Akdemir from comment #10) > I have attempted to fix the latter case too. The existing multiline field > wrapping is a two part hack. One part in ImpEditEngine::CreateLines the > other in ImpEditEngine::Paint. Expanding the hack to fix those cases are not > really feasible. Instead a proper refactor of the layouting/handling of > fields both in EditMode and Paint are required to properly display and wrap > multiline fields. I filed bug #154248 to make sure we keep this (and Timur's reproducer). |