Bug 149571

Summary:	Automatic font color should consider cell background instead of DefaultStyleSheet
Product:	LibreOffice	Reporter:	Eyal Rozenberg <eyalroz1>
Component:	Impress	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	minor	CC:	heiko.tietze, ilmari.lauhakangas, rafael.palma.lima
Priority:	medium	Keywords:	implementationError
Version:	4.4.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=142799 https://bugs.documentfoundation.org/show_bug.cgi?id=156685 https://bugs.documentfoundation.org/show_bug.cgi?id=157618 https://bugs.documentfoundation.org/show_bug.cgi?id=161057
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	100366, 157844
Attachments:	A presentation illustrating the issue

Description Eyal Rozenberg 2022-06-14 22:46:00 UTC

Created attachment 180772 [details]
A presentation illustrating the issue

Consider the attached single-slide presentation. It was originally created in Powerpoint, but the table was created in Impress.

* The text in the black-background column - is black.
* The text in the purple-background column - is black.
* The text in the transparent box in the title area is black, even though the underlying graphic is dark, night-colored even.

This, despite all text having been formatted in Automatic text color.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d9b33ed6644203141fdb0776c291425c2bc9f5ac
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

Comment 1 LeroyG 2022-06-15 18:53:59 UTC

Reproducible from scratch with:
Version: 7.2.7.2 (x86) / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: es-MX (es_MX); UI: en-US
Calc: threaded

Text is shown in black, until you edit the text in the table cell.

Comment 2 Eyal Rozenberg 2022-06-15 19:48:08 UTC

(In reply to LeroyG from comment #1)
> Reproducible from scratch

You mean, not with my file? If so, can you give reproduction instructions?

Also, this is actually two-issues-in-one: Dark area, and transparent area over a dark background object. Which did you reproduce?

Comment 3 Rafael Lima 2022-06-15 20:49:50 UTC

When you click the black-cell in the table to edit the text, the text gets a white color. But when you exit the cell, then text becomes black again. This does not seem to be the correct behavior - BUG.

As for the text in the transparent box saying "Automatic for the people", I believe the result is expected, since the box itself is transparent, so it can't know what's beneath it to determine text color - NAB.

Comment 4 Buovjaga 2023-01-19 08:38:12 UTC

Confirmed with file. Tested with many versions. Before 4.4 all of the cells have blue colour.

Arch Linux 64-bit, X11
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cf734427550f1a42f8ac669378719a1cad617bbb
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 19 January 2023

Comment 5 Heiko Tietze 2023-10-19 07:48:22 UTC

Font color is currently calculated against Light Blue 2, see https://gerrit.libreoffice.org/c/core/+/157568 (reverted).

Comment 6 Eyal Rozenberg 2023-10-19 08:14:28 UTC

(In reply to Heiko Tietze from comment #5)
> Font color is currently calculated against Light Blue 2, see
> https://gerrit.libreoffice.org/c/core/+/157568 (reverted).

So, what that supposed to be a fix, and got reverted? Why?

Or - was it an unrelated patch? I don't quite understand.