Bug 149575

Summary:	Setting image in XTabPageModel is not reflected in UI
Product:	LibreOffice	Reporter:	Ilhan Yesil <ilhanyesil>
Component:	sdk	Assignee:	Ilhan Yesil <ilhanyesil>
Status:	ASSIGNED ---
Severity:	normal	CC:	ilmari.lauhakangas, m.weghorn
Priority:	medium
Version:	7.4.0.0 alpha1+
Hardware:	All
OS:	All
Whiteboard:	target:7.5.0
Crash report or crash signature:		Regression By:
Attachments:	Sample extension to demontrate the issue Sources

Description Ilhan Yesil 2022-06-15 09:51:33 UTC

Description:
Calling XTabPageModel.setImageURL with a valid image url via UNO API doesn't set the image on the tab button of the tab page.

Steps to Reproduce:
1. install attached sample extension StarterProject.oxt
2. start Writer
3. open the extension's dialog via Menu using "Test Extension" -> "Show Dialog"
4. press the "set image" button

Actual Results:
Nothing seems to happen.

Expected Results:
The second tab should set an image beside the text


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 7905dba8a5c76eb7b4da5580e4f77e1a9b0dc8f0
CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: de-DE
9999TestM-NoUnit&Builds-NoPack-DebUti
Calc: CL

Comment 1 Ilhan Yesil 2022-06-15 09:53:45 UTC

Self confirming according to https://wiki.documentfoundation.org/QA/Guidelines_for_public_and_private_sector_deployments. Issue has originally been reported by another user in our internal issue tracker.

Comment 2 Ilhan Yesil 2022-06-15 10:01:36 UTC

Created attachment 180778 [details]
Sample extension to demontrate the issue

Comment 3 Ilhan Yesil 2022-06-15 10:05:53 UTC

Created attachment 180779 [details]
Sources

Comment 4 Commit Notification 2022-06-17 06:15:36 UTC

Ilhan Yesil committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0f1837306ae5c2c2e10f256b872c46b0bfba00dd

tdf#149575 UnoControlTabPageContainer: Handle tab image

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 5 Buovjaga 2022-07-03 14:58:41 UTC

Thanks for the patch, is there anything more to be done or will you close it as fixed?

(In reply to Ilhan Yesil from comment #1)
> Self confirming according to
> https://wiki.documentfoundation.org/QA/
> Guidelines_for_public_and_private_sector_deployments. Issue has originally
> been reported by another user in our internal issue tracker.

Are you working for City of Munich, then?