Bug 149598

Summary: "Format cells" dialog does not remember size
Product: LibreOffice Reporter: Dan Dascalescu <ddascalescu+freedesktop>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: REOPENED ---    
Severity: enhancement CC: buzea.bogdan, jbfaure
Priority: low    
Version: 7.2.7.2 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=101285
https://bugs.documentfoundation.org/show_bug.cgi?id=156710
Whiteboard: target:7.6.3
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 108019    
Attachments: Narrow number format column, cramped tabs
before and after
screenshot

Description Dan Dascalescu 2022-06-17 23:47:21 UTC
Created attachment 180816 [details]
Narrow number format column, cramped tabs

Every time I right click on a cell and choose Format Cells, I have to resize that dialog in order to see the user-defined formats in their entirety.

Would it be possible to remember the size of this dialog?

Similar to bug 101285.
Comment 1 Timur 2022-07-04 13:15:28 UTC
New.
Comment 2 Commit Notification 2023-06-01 08:56:22 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c1893df42567c260ca5fb069038d1a55616e7b7f

tdf#149598 - Remember window state of the format cell dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 BogdanB 2023-06-01 18:03:05 UTC
Thanks, Andreas for fixing this, and Dan for reporting.

Much better in
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: d7d2b172065f90aa2f61c0216f3722e868ae76a1
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Smaller in (for reference)
Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 BogdanB 2023-06-01 18:03:28 UTC
Created attachment 187646 [details]
before and after
Comment 5 BogdanB 2023-06-01 18:05:37 UTC
Created attachment 187647 [details]
screenshot

After resizing to maximum, and reopened, I get this.
Comment 6 Jean-Baptiste Faure 2023-10-06 12:06:35 UTC
(In reply to Commit Notification from comment #2)
> Andreas Heinisch committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> c1893df42567c260ca5fb069038d1a55616e7b7f
> 
> tdf#149598 - Remember window state of the format cell dialog
> 
> It will be available in 7.6.0.
> [...]
> Affected users are encouraged to test the fix and report feedback.

I suggest to revert this commit because it causes the regression bug 156710.

Reopening because the fix is incorrect.

Best regards.
Comment 7 Commit Notification 2023-10-07 06:49:41 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f1f2a3faeaddf9e9a59f44bf9de38a1f0aa97104

Revert "tdf#149598 - Remember window state of the format cell dialog"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-10-09 11:06:17 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/a0faa0bca2bcd6929d178ad40237addec98090c5

Revert "tdf#149598 - Remember window state of the format cell dialog"

It will be available in 7.6.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.