| Summary: | Clone Formatting does not apply glow effects | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | xordevoreaux |
| Component: | Draw | Assignee: | Julien Nabet <serval2412> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | rafael.palma.lima, serval2412 |
| Priority: | medium | ||
| Version: | 7.3.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=130252 | ||
| Whiteboard: | target:7.5.0 target:7.4.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 114912 | ||
|
Description
xordevoreaux
2022-07-03 00:20:41 UTC
Repro with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 61f5c991a97de8990badfed6ef840941b5aa8c7f CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded Glow effect is not considered by the Clone Formatting tool. On pc Debian x86-64 with master sources updated today, I could reproduce this. I got a patch not yet submitted on gerrit because I'm waiting feedback for the patch about tdf#130252 put in see also. Indeed, to fix this one correctly, we need tdf#130252 to be fixed first. (In reply to Julien Nabet from comment #2) > I got a patch not yet submitted on gerrit because I'm waiting feedback for > the patch about tdf#130252 put in see also. > Indeed, to fix this one correctly, we need tdf#130252 to be fixed first. Hi Julien, thanks for taking interest in this issue. Since you're at it, the new Soft Edge effect has the same problem and it is not copied by the clone formatting tool. Could you please address this issue as well? (In reply to Rafael Lima from comment #3) > ... > Hi Julien, thanks for taking interest in this issue. > > Since you're at it, the new Soft Edge effect has the same problem and it is > not copied by the clone formatting tool. Could you please address this issue > as well? Yes I saw it too. It requires to add the range SDRATTR_SOFTEDGE_FIRST SDRATTR_SOFTEDGE_LAST in GetFormatRangeImpl method (see https://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdedxv.cxx?r=226847e3#2654) BUT both constants of this range are defined like this: 426 constexpr sal_uInt16 SDRATTR_SOFTEDGE_FIRST(SDRATTR_GLOW_LAST + 1); (427 constexpr TypedWhichId<SdrMetricItem> SDRATTR_SOFTEDGE_RADIUS(SDRATTR_SOFTEDGE_FIRST + 0);) 428 constexpr sal_uInt16 SDRATTR_SOFTEDGE_LAST(SDRATTR_SOFTEDGE_RADIUS); So there's only 1 real attribute and SDRATTR_SOFTEDGE_LAST = SDRATTR_SOFTEDGE_RADIUS = SDRATTR_SOFTEDGE_FIRST therefore the prerequisite is to have tdf#130252 fixed. I've just set tdf#130252 as FIXED since the patch has been pushed. So I've submitted https://gerrit.libreoffice.org/c/core/+/136787 (which includes SOFTEDGE_RADIUS) Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d2dfc0c4286057f5d8dda178817de3503c3a7d29 tdf#149822: Clone Formatting does not apply glow effects It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I've submitted the patch for 7.4 branch here: https://gerrit.libreoffice.org/c/core/+/136759 Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/519d358b5c227610e21f41b28b9400296d66991f tdf#149822: Clone Formatting does not apply glow effects It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |